From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0156C001DC for ; Tue, 11 Jul 2023 13:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232865AbjGKNKE (ORCPT ); Tue, 11 Jul 2023 09:10:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232752AbjGKNKD (ORCPT ); Tue, 11 Jul 2023 09:10:03 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB989188; Tue, 11 Jul 2023 06:10:02 -0700 (PDT) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1qJD7v-0002JU-9d; Tue, 11 Jul 2023 15:09:59 +0200 Message-ID: Date: Tue, 11 Jul 2023 15:09:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Reply-To: Linux regressions mailing list Subject: Re: [PATCH] HID: logitech-hidpp: rework one more time the retries attempts Content-Language: en-US, de-DE To: Benjamin Tissoires , Bastien Nocera Cc: Greg KH , =?UTF-8?Q?Filipe_La=c3=adns?= , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230621-logitech-fixes-v1-1-32e70933c0b0@redhat.com> <2023062156-trespass-pandemic-7f4f@gregkh> <31ce32e018a9fa410e9e1f3e5900621b16a56091.camel@hadess.net> From: "Linux regression tracking (Thorsten Leemhuis)" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1689081002;13510ddf; X-HE-SMSGID: 1qJD7v-0002JU-9d Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 26.06.23 16:02, Benjamin Tissoires wrote: > On Sun, Jun 25, 2023 at 10:30 AM Bastien Nocera wrote: >> On Fri, 2023-06-23 at 10:37 +0200, Benjamin Tissoires wrote: >>> On Jun 21 2023, Greg KH wrote: >>>> On Wed, Jun 21, 2023 at 11:42:30AM +0200, Benjamin Tissoires wrote: >>>>> Make the code looks less like Pascal. >>>>> >>>>> Extract the internal code inside a helper function, fix the >>>>> initialization of the parameters used in the helper function >>>>> (`hidpp->answer_available` was not reset and `*response` wasn't >>>>> too), >>>>> and use a `do {...} while();` loop. >>>>> >>>>> Fixes: 586e8fede795 ("HID: logitech-hidpp: Retry commands when >>>>> device is busy") >>>>> Cc: stable@vger.kernel.org >>>>> Signed-off-by: Benjamin Tissoires >>>>> --- >>>>> as requested by >>>>> https://lore.kernel.org/all/CAHk-=wiMbF38KCNhPFiargenpSBoecSXTLQACKS2UMyo_Vu2ww@mail.gmail.com/ >>>>> This is a rewrite of that particular piece of code. >>>>> --- >>>>> drivers/hid/hid-logitech-hidpp.c | 102 +++++++++++++++++++++++-- >>>>> -------------- >>>>> 1 file changed, 61 insertions(+), 41 deletions(-) > [...] > > Some people on the Bz were able to reproduce with multiple reboots. > But it's not as urgent as previously, and we were close to the 6.4 > final when I sent it. I'll make sure this goes into 6.5 and gets > proper stable backports FWIW. Did that happen? Doesn't look like it from here, but maybe I'm missing something. Where there maybe other changes to resolve the remaining problems some users encounter sporadically since the urgent fixes went in? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.