linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anirudh Ghayal <anirudhghayal@gmail.com>
To: Sriramakrishnan <srk@ti.com>
Cc: linux-omap@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416
Date: Sun, 28 Feb 2010 00:27:47 +0530	[thread overview]
Message-ID: <cfb943981002271057t75fe7decy99875c9dbd7721ec@mail.gmail.com> (raw)
In-Reply-To: <1267103701-23823-2-git-send-email-srk@ti.com>

Hi,

> +
> +       chip = kzalloc(sizeof(struct tca6416_keypad_chip), GFP_KERNEL);
> +       if (chip == NULL)
> +               return -ENOMEM;

Check for i2c functionality support ?

> +               ret = request_irq(chip->irqnum, tca6416_keys_isr,
> +                               IRQF_SHARED | IRQF_TRIGGER_FALLING ,
> +                               "tca6416-keypad", chip);
> +               if (ret) {
> +                       dev_dbg(&client->dev,
> +                               "Unable to claim irq %d; error %d\n",
> +                               chip->irqnum, ret);
> +                       goto fail3;
> +               }
> +               disable_irq(chip->irqnum);

The error path needs to free_irq() in case of any failure after this,
for an interrupt based driver.

Thanks,
Anirudh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2010-02-27 18:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 13:14 [PATCH 0/3] Add support for TCA6416 based Keypad driver Sriramakrishnan
2010-02-25 13:14 ` [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416 Sriramakrishnan
2010-02-25 13:15   ` [PATCH 2/3] AM3517 EVM : Enable TCA6416 keypad Sriramakrishnan
2010-02-25 13:15     ` [PATCH 3/3] AM3517: Board hookup for TCA6416 keypad driver Sriramakrishnan
2010-02-25 18:47   ` [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416 Felipe Balbi
2010-02-26  8:28     ` Dmitry Torokhov
2010-02-26 14:43       ` Govindarajan, Sriramakrishnan
2010-02-27  9:00         ` Dmitry Torokhov
2010-03-05 15:06           ` Govindarajan, Sriramakrishnan
2010-02-27 18:57   ` Anirudh Ghayal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfb943981002271057t75fe7decy99875c9dbd7721ec@mail.gmail.com \
    --to=anirudhghayal@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=srk@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).