From: Jani Nikula <ext-jani.1.nikula@nokia.com>
To: alek.du@intel.com
Cc: dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, soni.trilok@gmail.com,
ben-linux@fluff.org, ext-phil.2.carmody@nokia.com,
ext-jani.1.nikula@nokia.com
Subject: [PATCH 0/2] fix gpio-keys debouncing and timer sleep issues
Date: Fri, 26 Jun 2009 15:15:16 +0300 [thread overview]
Message-ID: <cover.1246015395.git.ext-jani.1.nikula@nokia.com> (raw)
In-Reply-To: <20090626002345.07928230@dxy.sh.intel.com>
Alek, someone might depend on how debouncing worked before, so let's not
break it. I, for one, am looking at using this in the future, and would
want this to work as it was before.
Why don't we fix this instead of debating? For simplicity, here's first
a revert of the original patch and then a fix to the sleep issue.
Unfortunately, I do not have the equipment to properly test this right
now.
Could you please review and test this if you have the equipment? Add
your signed-off-by and comments, of course. Would that be okay?
BR,
Jani.
Jani Nikula (2):
Revert "Input: gpio-keys - change timer to workqueue"
input: gpio-keys: avoid possibility of sleeping in timer function
drivers/input/keyboard/gpio_keys.c | 33 ++++++++++++++++++++++++---------
1 files changed, 24 insertions(+), 9 deletions(-)
next prev parent reply other threads:[~2009-06-26 12:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 7:24 [PATCH]input: Change timer function to workqueue for gpio_keys driver Alek Du
2009-06-12 17:40 ` Trilok Soni
2009-06-25 10:29 ` Jani Nikula
2009-06-25 13:06 ` Alek Du
2009-06-25 13:31 ` Jani Nikula
2009-06-25 14:08 ` Alek Du
2009-06-25 14:52 ` Jani Nikula
2009-06-25 15:05 ` Jani Nikula
2009-06-25 15:09 ` Alek Du
2009-06-25 15:42 ` Jani Nikula
2009-06-25 15:48 ` Alek Du
2009-06-25 16:09 ` Phil Carmody
2009-06-25 16:23 ` Alek Du
2009-06-25 16:42 ` Dmitry Torokhov
2009-06-26 12:15 ` Jani Nikula [this message]
2009-06-26 12:15 ` [PATCH 1/2] Revert "Input: gpio-keys - change timer to workqueue" Jani Nikula
2009-06-26 12:15 ` [PATCH 2/2] input: gpio-keys: avoid possibility of sleeping in timer function Jani Nikula
2009-06-29 10:30 ` Alek Du
2009-06-26 12:50 ` [PATCH 0/2] fix gpio-keys debouncing and timer sleep issues Du, Alek
2009-06-29 5:59 ` Dmitry Torokhov
2009-06-29 10:32 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1246015395.git.ext-jani.1.nikula@nokia.com \
--to=ext-jani.1.nikula@nokia.com \
--cc=alek.du@intel.com \
--cc=ben-linux@fluff.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).