[PATCH v2 0/2] HID: HID_APPLETB_KBD and HID_APPLETB_BL should depend on X86

[PATCH v2 0/2] HID: HID_APPLETB_KBD and HID_APPLETB_BL should depend on X86

[Geert Uytterhoeven]

	Hi all,

The Apple Touch Bar is only present on x86 MacBook Pros.  Hence this
patch series adds dependencies on X86, to prevent asking the user about
its drivers when configuring a kernel for a different architecture.

Changes compared to v1[1]:
  - Split in two patches,
  - Correct Fixes.

Thanks!

[1] "HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on X86"
    https://lore.kernel.org/4b046ce1cae2170453037c7ea006c91c12383dab.1744190441.git.geert+renesas@glider.be

Geert Uytterhoeven (2):
  HID: HID_APPLETB_KBD should depend on X86
  HID: HID_APPLETB_BL should depend on X86

 drivers/hid/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.43.0

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH v2 1/2] HID: HID_APPLETB_KBD should depend on X86

[Geert Uytterhoeven]

The Apple Touch Bar is only present on x86 MacBook Pros.  Hence add a
dependency on X86, to prevent asking the user about this driver when
configuring a kernel for a different architecture.

Fixes: 8e9b9152cfbdc2a9 ("HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This is v2 of "HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on
X86".

v2:
  - Split in two patches,
  - Correct Fixes.
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index a503252702b7b43c..119e5190a2df786e 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -163,6 +163,7 @@ config HID_APPLETB_KBD
 	depends on USB_HID
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on INPUT
+	depends on X86 || COMPILE_TEST
 	select INPUT_SPARSEKMAP
 	select HID_APPLETB_BL
 	help
-- 
2.43.0

Re: [PATCH v2 1/2] HID: HID_APPLETB_KBD should depend on X86

[Aditya Garg]

> On 10 Apr 2025, at 2:01 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> 
> The Apple Touch Bar is only present on x86 MacBook Pros.  Hence add a
> dependency on X86, to prevent asking the user about this driver when
> configuring a kernel for a different architecture.

There are a lot of spaces before Hence. Also, Apple Touch Bar is present on some Arm MacBooks as well, so probably mention that this driver is only for touchbars on x86 Macs and there is a separate driver for the Arm Macs.

Anyways it's Jiri's and your call regarding this change.
> 
> Fixes: 8e9b9152cfbdc2a9 ("HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This is v2 of "HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on
> X86".
> 
> v2:
>  - Split in two patches,
>  - Correct Fixes.
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index a503252702b7b43c..119e5190a2df786e 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -163,6 +163,7 @@ config HID_APPLETB_KBD
>    depends on USB_HID
>    depends on BACKLIGHT_CLASS_DEVICE
>    depends on INPUT
> +    depends on X86 || COMPILE_TEST
>    select INPUT_SPARSEKMAP
>    select HID_APPLETB_BL
>    help
> --
> 2.43.0
> 

Re: [PATCH v2 1/2] HID: HID_APPLETB_KBD should depend on X86

[Geert Uytterhoeven]

Hi Aditya,

On Thu, 10 Apr 2025 at 10:52, Aditya Garg <gargaditya08@live.com> wrote:
> > On 10 Apr 2025, at 2:01 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > The Apple Touch Bar is only present on x86 MacBook Pros.  Hence add a
> > dependency on X86, to prevent asking the user about this driver when
> > configuring a kernel for a different architecture.
>
> There are a lot of spaces before Hence.

That is intentional: double space between sentences.

> Also, Apple Touch Bar is present on some Arm MacBooks as well, so probably mention that this driver is only for touchbars on x86 Macs and there is a separate driver for the Arm Macs.

Why is there a separate driver for Arm Macs?
Which driver is that?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 1/2] HID: HID_APPLETB_KBD should depend on X86

[Aditya Garg]

On 10-04-2025 08:10 pm, Geert Uytterhoeven wrote:
> Hi Aditya,
> 
> On Thu, 10 Apr 2025 at 10:52, Aditya Garg <gargaditya08@live.com> wrote:
>>> On 10 Apr 2025, at 2:01 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>>> The Apple Touch Bar is only present on x86 MacBook Pros.  Hence add a
>>> dependency on X86, to prevent asking the user about this driver when
>>> configuring a kernel for a different architecture.
>>
>> There are a lot of spaces before Hence.
> 
> That is intentional: double space between sentences.

Interesting choice

> 
>> Also, Apple Touch Bar is present on some Arm MacBooks as well, so probably mention that this driver is only for touchbars on x86 Macs and there is a separate driver for the Arm Macs.
> 
> Why is there a separate driver for Arm Macs?

Because it is a completely different hardware on M1 Macs. On x86 Macs, it is a USB device + has both keyboard and drm mode. The keyboard mode makes it display a predefined set of keys and was made for Windows Bootcamp. The DRM mode, makes it a separate display, made for macOS.

On the M1s, it is not a USB device, nor has a keyboard mode. I forgot what exactly it used at the lower level, but it was quite different from the x86 Macs

> Which driver is that?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/adp/adp_drv.c?h=v6.15-rc1
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/input/touchscreen/apple_z2.c?h=v6.15-rc1
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 

[PATCH v2 2/2] HID: HID_APPLETB_BL should depend on X86

[Geert Uytterhoeven]

The Apple Touch Bar is only present on x86 MacBook Pros.  Hence add a
dependency on X86, to prevent asking the user about this driver when
configuring a kernel for a different architecture.

Fixes: 1fd41e5e3d7cc556 ("HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This is v2 of "HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on
X86".

v2:
  - Split in two patches.
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 119e5190a2df786e..43859fc757470caf 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -151,6 +151,7 @@ config HID_APPLEIR
 config HID_APPLETB_BL
 	tristate "Apple Touch Bar Backlight"
 	depends on BACKLIGHT_CLASS_DEVICE
+	depends on X86 || COMPILE_TEST
 	help
 	  Say Y here if you want support for the backlight of Touch Bars on x86
 	  MacBook Pros.
-- 
2.43.0

Re: [PATCH v2 0/2] HID: HID_APPLETB_KBD and HID_APPLETB_BL should depend on X86

[Aditya Garg]

On 10-04-2025 02:00 pm, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> The Apple Touch Bar is only present on x86 MacBook Pros.  Hence this
> patch series adds dependencies on X86, to prevent asking the user about
> its drivers when configuring a kernel for a different architecture.
> 
> Changes compared to v1[1]:
>   - Split in two patches,
>   - Correct Fixes.
> 
> Thanks!
> 
> [1] "HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on X86"
>     https://lore.kernel.org/4b046ce1cae2170453037c7ea006c91c12383dab.1744190441.git.geert+renesas@glider.be
> 
> Geert Uytterhoeven (2):
>   HID: HID_APPLETB_KBD should depend on X86
>   HID: HID_APPLETB_BL should depend on X86
> 
>  drivers/hid/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 

I forgot about this btw:

Reviewed-by: Aditya Garg <gargaditya08@live.com>

As far as the subject change is considered, your call.

Re: [PATCH v2 0/2] HID: HID_APPLETB_KBD and HID_APPLETB_BL should depend on X86

[Jiri Kosina]

On Thu, 10 Apr 2025, Geert Uytterhoeven wrote:

> 	Hi all,
> 
> The Apple Touch Bar is only present on x86 MacBook Pros.  Hence this
> patch series adds dependencies on X86, to prevent asking the user about
> its drivers when configuring a kernel for a different architecture.
> 
> Changes compared to v1[1]:
>   - Split in two patches,
>   - Correct Fixes.
> 
> Thanks!
> 
> [1] "HID: HID_APPLETB_BL and HID_APPLETB_KBD should depend on X86"
>     https://lore.kernel.org/4b046ce1cae2170453037c7ea006c91c12383dab.1744190441.git.geert+renesas@glider.be
> 
> Geert Uytterhoeven (2):
>   HID: HID_APPLETB_KBD should depend on X86
>   HID: HID_APPLETB_BL should depend on X86
> 
>  drivers/hid/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs