From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: Fix locking in mousedev Date: Fri, 9 Mar 2007 15:54:39 -0500 Message-ID: References: <20070228110631.86a150e4.zaitcev@redhat.com> <20070309103656.cd681677.zaitcev@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070309103656.cd681677.zaitcev@redhat.com> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Pete Zaitcev Cc: linux-kernel@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz List-Id: linux-input@vger.kernel.org On 3/9/07, Pete Zaitcev wrote: > On Fri, 9 Mar 2007 09:28:49 -0500, "Dmitry Torokhov" wrote: > > On 2/28/07, Pete Zaitcev wrote: > > > > Dmitry, please consider getting rid of the list of handles entirely. > > > The other major user is drivers/char/keyboard.c. > > > > I agree that handlers should not access h_list nad use their own > > private lists instead. However input core still needs that list to > > maintain its books. > > Hmm. So it appears that my patch wastes 2 ulongs per input handle > then, in the name of preventing oopses. OK. > Think about the time when everyone switches to evdev-based input drivers. Then we can forget about mousedev wasting some extra memory ;) -- Dmitry