linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-input <linux-input@atrey.karlin.mff.cuni.cz>
Subject: Re: bug in evdev_disconnect
Date: Fri, 27 Apr 2007 15:07:39 -0400	[thread overview]
Message-ID: <d120d5000704271207t3b86d32fu88f438fe3efbc612@mail.gmail.com> (raw)
In-Reply-To: <1177683991.3565.8.camel@johannes.berg>

Hi Johannes,

On 4/27/07, Johannes Berg <johannes@sipsolutions.net> wrote:
>
> Obviously there's a use-after-free condition, but I can't really make
> out where it is. The disassembly seems to point to
>                list_for_each_entry(list, &evdev->list, node)
>                        kill_fasync(&list->fasync, SIGIO, POLL_HUP);
> in evdev_disconnect.
>
> Has somebody seen this before? It seems to happen only if userspace has
> the device open or so.
>

Please try -mm, it should be fixed there. As a temporary work wround
you can also swap list_for_each() and wake_up_interruptible() in
evdev_disconnect().

-- 
Dmitry

  reply	other threads:[~2007-04-27 19:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-27 14:26 bug in evdev_disconnect Johannes Berg
2007-04-27 19:07 ` Dmitry Torokhov [this message]
2007-04-27 19:58   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d5000704271207t3b86d32fu88f438fe3efbc612@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).