linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: Aristeu Rozanski <arozansk@redhat.com>
Cc: linux-input@atrey.karlin.mff.cuni.cz, Chris Williams <cww@redhat.com>
Subject: Re: [RFC] psmouse: add support for 4th button using the 4th bit
Date: Wed, 9 May 2007 10:36:57 -0400	[thread overview]
Message-ID: <d120d5000705090736p145b6a7cn8645eccdb5c35ca3@mail.gmail.com> (raw)
In-Reply-To: <20070508185327.GB4215@redhat.com>

Hi Aristeu,

On 5/8/07, Aristeu Rozanski <arozansk@redhat.com> wrote:
> Hi Dmitry,
> > You'd need to add something like this to psmouse_protocols[]:
> >
> >        {
> >                .type           = PSMOUSE_CORTRON,
> >                .name           = "CortronPS/2",
> >                .alias          = "cortps",
> >                .detect         = cortron_detect,
> >        },
> >
> > and then model cortron_detect after ps2bare_detect (where you don't
> > actually detect anything, just force protocol).
> we asked Cortron again about a possible auto-detection sequence but they
> didn't implemented anything in this matter. So I updated the patch
> according your recomendations and Chris tested again with the Trackball,
> with success. If you're ok with that, I'll resubmit it with proper
> description/signed-off-by header.
>

Looks good, please resend. There may be issues with box losing
manually set protocols when coming out of suspend but that's for
another patch.

Thank you.

-- 
Dmitry

  reply	other threads:[~2007-05-09 14:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-02 20:48 [RFC] psmouse: add support for 4th button using the 4th bit Aristeu Rozanski
2007-04-03 14:39 ` Dmitry Torokhov
2007-04-03 14:42   ` Aristeu Rozanski
2007-04-03 15:05     ` Dmitry Torokhov
2007-04-03 15:23       ` Aristeu Rozanski
2007-05-08 18:53       ` Aristeu Rozanski
2007-05-09 14:36         ` Dmitry Torokhov [this message]
2007-05-09 14:53           ` [PATCH] " Aristeu Rozanski
2007-05-09 15:39             ` Dmitry Torokhov
2007-05-09 15:49               ` Aristeu Rozanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d5000705090736p145b6a7cn8645eccdb5c35ca3@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=arozansk@redhat.com \
    --cc=cww@redhat.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).