From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [RFC] psmouse: add support for 4th button using the 4th bit Date: Wed, 9 May 2007 10:36:57 -0400 Message-ID: References: <20070402204810.GC14838@redhat.com> <20070403144243.GE14838@redhat.com> <20070508185327.GB4215@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070508185327.GB4215@redhat.com> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Aristeu Rozanski Cc: linux-input@atrey.karlin.mff.cuni.cz, Chris Williams List-Id: linux-input@vger.kernel.org Hi Aristeu, On 5/8/07, Aristeu Rozanski wrote: > Hi Dmitry, > > You'd need to add something like this to psmouse_protocols[]: > > > > { > > .type = PSMOUSE_CORTRON, > > .name = "CortronPS/2", > > .alias = "cortps", > > .detect = cortron_detect, > > }, > > > > and then model cortron_detect after ps2bare_detect (where you don't > > actually detect anything, just force protocol). > we asked Cortron again about a possible auto-detection sequence but they > didn't implemented anything in this matter. So I updated the patch > according your recomendations and Chris tested again with the Trackball, > with success. If you're ok with that, I'll resubmit it with proper > description/signed-off-by header. > Looks good, please resend. There may be issues with box losing manually set protocols when coming out of suspend but that's for another patch. Thank you. -- Dmitry