* [PATCH] Fix spitzkbd compile warnings
@ 2007-05-13 12:35 Richard Purdie
2007-05-13 13:16 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Richard Purdie @ 2007-05-13 12:35 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
Fix compile warnings from spitzkbd.c. Registration failure of these IRQs
isn't fatal so just warn about it.
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
diff --git a/drivers/input/keyboard/spitzkbd.c b/drivers/input/keyboard/spitzkbd.c
index 41b8038..a609d43 100644
--- a/drivers/input/keyboard/spitzkbd.c
+++ b/drivers/input/keyboard/spitzkbd.c
@@ -418,21 +418,26 @@ static int __init spitzkbd_probe(struct platform_device *dev)
pxa_gpio_mode(SPITZ_GPIO_SWA | GPIO_IN);
pxa_gpio_mode(SPITZ_GPIO_SWB | GPIO_IN);
- request_irq(SPITZ_IRQ_GPIO_SYNC, spitzkbd_interrupt,
+ if (request_irq(SPITZ_IRQ_GPIO_SYNC, spitzkbd_interrupt,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd Sync", spitzkbd);
- request_irq(SPITZ_IRQ_GPIO_ON_KEY, spitzkbd_interrupt,
+ "Spitzkbd Sync", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request sync IRQ\n");
+ if (request_irq(SPITZ_IRQ_GPIO_ON_KEY, spitzkbd_interrupt,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd PwrOn", spitzkbd);
- request_irq(SPITZ_IRQ_GPIO_SWA, spitzkbd_hinge_isr,
+ "Spitzkbd PwrOn", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request GPIO IRQ\n");
+ if (request_irq(SPITZ_IRQ_GPIO_SWA, spitzkbd_hinge_isr,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd SWA", spitzkbd);
- request_irq(SPITZ_IRQ_GPIO_SWB, spitzkbd_hinge_isr,
+ "Spitzkbd SWA", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request SWA IRQ\n");
+ if (request_irq(SPITZ_IRQ_GPIO_SWB, spitzkbd_hinge_isr,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd SWB", spitzkbd);
- request_irq(SPITZ_IRQ_GPIO_AK_INT, spitzkbd_hinge_isr,
+ "Spitzkbd SWB", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request SWB IRQ\n");
+ if (request_irq(SPITZ_IRQ_GPIO_AK_INT, spitzkbd_hinge_isr,
IRQF_DISABLED | IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
- "Spitzkbd HP", spitzkbd);
+ "Spitzkbd HP", spitzkbd))
+ printk(KERN_WARNING "spitzkbd: Failed to request AK IRQ\n");
return 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix spitzkbd compile warnings
2007-05-13 12:35 [PATCH] Fix spitzkbd compile warnings Richard Purdie
@ 2007-05-13 13:16 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2007-05-13 13:16 UTC (permalink / raw)
To: Richard Purdie; +Cc: linux-input
Hi Richard,
On 5/13/07, Richard Purdie <rpurdie@rpsys.net> wrote:
> Fix compile warnings from spitzkbd.c. Registration failure of these IRQs
> isn't fatal so just warn about it.
>
Could we also print error codes returned by request_irq()?
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-13 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-13 12:35 [PATCH] Fix spitzkbd compile warnings Richard Purdie
2007-05-13 13:16 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).