Re: [PATCH] USB: driver for CM109 chipset

["Dmitry Torokhov" <dmitry.torokhov@gmail.com>]

Hi Alfred,

On 6/25/07, Alfred E. Heggestad <aeh@db.org> wrote:
> From: Alfred E. Heggestad <aeh@db.org>
>
> This driver adds support for USB VoIP phones using the CM109 chipset,
> such as the KIP-1000. Keypad is scanned and events are reported to
> the input subsystem. The buzzer can be activated by sending SND_TONE
> or SND_BELL to the input device.
> The driver has been tested with linux 2.6.21.3 on i386 and AMD64,
> and linux 2.6.21.1 on Broadcom BCM3302 (MIPS, OpenWRT Project)
> The current patch applies cleanly and is tested on linux 2.6.22-rc4
> More testing and code review is welcome..
>

Thank you for your patch. I have couple of comments:

- "input_dev->cdev.dev = &intf->dev;" should be "input_dev->dev.parent
= &intf->dev;"
- do not access input->private directly; use input_set_drvdata() and
input_get_drvdata() helpers.
- error handling for input_register_device();
- I guess we need KEY_POUNDSIGN because I don't like that business
with key_shift + key_3 (I did not like it in yealink either...)

Also could you please send your patches inline instead of an
attachment - it makes much easire to comment that way.

Thanks!

-- 
Dmitry