From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: Soeren Sonnenburg <kernel@nn7.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-usb-devel@lists.sourceforge.net,
Matthew Garrett <mjg59@srcf.ucam.org>,
Nicolas Boichat <nicolas@boichat.ch>,
Michael Hanselmann <linux-kernel@hansmi.ch>,
Peter Osterlund <petero2@telia.com>,
Frank Arnold <frank@scirocco-5v-turbo.de>,
Stelian Pop <stelian@popies.net>,
Johannes Berg <johannes@sipsolutions.net>,
Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1
Date: Tue, 17 Jul 2007 11:01:48 -0400 [thread overview]
Message-ID: <d120d5000707170801u27e11936h9546bd36da7a1162@mail.gmail.com> (raw)
In-Reply-To: <1184656218.14051.43.camel@localhost>
Hi,
On 7/17/07, Soeren Sonnenburg <kernel@nn7.de> wrote:
>
> err_free_buffer:
> @@ -656,6 +699,7 @@ static void atp_disconnect(struct usb_interface *iface)
>
> usb_set_intfdata(iface, NULL);
> if (dev) {
> + cancel_work_sync(&dev->work);
> usb_kill_urb(dev->urb);
> input_unregister_device(dev->input);
> usb_buffer_free(dev->udev, dev->datalen,
>
This should go into atp_close() and I think you need to do
cancel_work_sync after calling usb_kill_urb() otherwise you risk it
being submitted while you gettingto kill the urb.
How many boxes did you try this patch on?
--
Dmitry
next prev parent reply other threads:[~2007-07-17 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 7:10 [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 Soeren Sonnenburg
2007-07-17 13:03 ` Johannes Berg
2007-07-17 16:14 ` Soeren Sonnenburg
2007-07-17 15:01 ` Dmitry Torokhov [this message]
2007-07-17 18:16 ` [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 take #3 Soeren Sonnenburg
2007-07-18 1:48 ` Dmitry Torokhov
2007-07-18 5:32 ` Soeren Sonnenburg
2007-07-18 22:57 ` [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 Andrew Morton
2007-07-19 3:35 ` [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 - take #4 Soeren Sonnenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000707170801u27e11936h9546bd36da7a1162@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=frank@scirocco-5v-turbo.de \
--cc=greg@kroah.com \
--cc=johannes@sipsolutions.net \
--cc=kernel@nn7.de \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@hansmi.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=mjg59@srcf.ucam.org \
--cc=nicolas@boichat.ch \
--cc=petero2@telia.com \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).