From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH] xpad: fix Kconfig to avoid compile error Date: Tue, 18 Sep 2007 13:52:11 -0400 Message-ID: References: <20070918090033.GB14882@devil> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070918090033.GB14882@devil> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Andreas Herrmann Cc: Jan Kratochvil , linux-input@atrey.karlin.mff.cuni.cz, linux-joystick@atrey.karlin.mff.cuni.cz List-Id: linux-input@vger.kernel.org Hi Andreas, On 9/18/07, Andreas Herrmann wrote: > With LEDS_CLASS=m && JOYSTICK_XPAD_LEDS=y I get following compile error: > > ... > LD .tmp_vmlinux1 > drivers/built-in.o: In function `xpad_disconnect': > xpad.c:(.text+0xb3d6b): undefined reference to `led_classdev_unregister' > drivers/built-in.o: In function `xpad_probe': > xpad.c:(.text+0xb48a6): undefined reference to `led_classdev_register' > make: *** [.tmp_vmlinux1] Error 1 > ... > > To avoid this kernel configuration, do auto-select LEDS_CLASS > for JOYSTCK_XPAD_LEDS. > I'd rather it depend on LEDS_CLASS (but properly). I believe I posted a patch yesterday. -- Dmitry