[PATCH] xpad: fix Kconfig to avoid compile error

[PATCH] xpad: fix Kconfig to avoid compile error

[Andreas Herrmann]

With LEDS_CLASS=m && JOYSTICK_XPAD_LEDS=y I get following compile error:

    ...
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `xpad_disconnect':
xpad.c:(.text+0xb3d6b): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `xpad_probe':
xpad.c:(.text+0xb48a6): undefined reference to `led_classdev_register'
make: *** [.tmp_vmlinux1] Error 1
    ...

To avoid this kernel configuration, do auto-select LEDS_CLASS
for JOYSTCK_XPAD_LEDS.

Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
---
 drivers/input/joystick/Kconfig |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
index e2abe18..d765eb7 100644
--- a/drivers/input/joystick/Kconfig
+++ b/drivers/input/joystick/Kconfig
@@ -277,7 +277,9 @@ config JOYSTICK_XPAD_FF
 
 config JOYSTICK_XPAD_LEDS
 	bool "LED Support for Xbox360 controller 'BigX' LED"
-	depends on LEDS_CLASS && JOYSTICK_XPAD
+	depends on JOYSTICK_XPAD
+	select NEW_LEDS
+	select LEDS_CLASS
 	---help---
 	  This option enables support for the LED which surrounds the Big X on
 	  XBox 360 controller.
-- 
1.5.3

RE: [PATCH] xpad: fix Kconfig to avoid compile error

[Charles Chambers]

[-- Attachment #1: Type: text/html, Size: 300 bytes --]

Re: [PATCH] xpad: fix Kconfig to avoid compile error

[Dmitry Torokhov]

On 9/18/07, Charles Chambers <cchamb2@hotmail.com> wrote:
>
>
>
> Could somebody please correct the security issue on this server?
>
> I've been getting spam originating on it for almost a year.
>
> The volume is becoming large enough that I'm considering blacklisting the
> server.

Unsubscribing from the mailing lists you are not interested in is
usually much easier.

-- 
Dmitry

List-Owner: <mailto:owner-linux-input@atrey.karlin.mff.cuni.cz>
List-Post: <mailto:linux-input@atrey.karlin.mff.cuni.cz>
List-Unsubscribe:
<mailto:linux-input-request@atrey.karlin.mff.cuni.cz?body=unsubscribe>
List-Help: <mailto:majordomo@atrey.karlin.mff.cuni.cz?body=help>

Re: [PATCH] xpad: fix Kconfig to avoid compile error

[Dmitry Torokhov]

Hi Andreas,

On 9/18/07, Andreas Herrmann <aherrman@arcor.de> wrote:
> With LEDS_CLASS=m && JOYSTICK_XPAD_LEDS=y I get following compile error:
>
>    ...
>  LD      .tmp_vmlinux1
> drivers/built-in.o: In function `xpad_disconnect':
> xpad.c:(.text+0xb3d6b): undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `xpad_probe':
> xpad.c:(.text+0xb48a6): undefined reference to `led_classdev_register'
> make: *** [.tmp_vmlinux1] Error 1
>    ...
>
> To avoid this kernel configuration, do auto-select LEDS_CLASS
> for JOYSTCK_XPAD_LEDS.
>

I'd rather it depend on LEDS_CLASS (but properly). I believe I posted
a patch yesterday.

-- 
Dmitry

Re: [PATCH] xpad: fix Kconfig to avoid compile error

[Andreas Herrmann]

On Tue, Sep 18, 2007 at 01:52:11PM -0400, Dmitry Torokhov wrote:
> > To avoid this kernel configuration, do auto-select LEDS_CLASS
> > for JOYSTCK_XPAD_LEDS.
> >
> 
> I'd rather it depend on LEDS_CLASS (but properly). I believe I posted
> a patch yesterday.

Didn't see this as I am not subscribed to one of the input or joystick mailing lists
(and didn't find any archive for that lists either).
So today I have checked your input.git tree on git.kernel.org.

Your patch (commit be1945c47248fa9c0a7cf4a04c1f4c32928656d2)
works fine if you rename LED_CLASS to LEDS_CLASS ...

So better fix that typo before your tree is pulled into Linus' tree.
;-)


Thanks and Regards,

Andreas

Re: [PATCH] xpad: fix Kconfig to avoid compile error

[Dmitry Torokhov]

On 9/19/07, Andreas Herrmann <aherrman@arcor.de> wrote:
> On Tue, Sep 18, 2007 at 01:52:11PM -0400, Dmitry Torokhov wrote:
> > > To avoid this kernel configuration, do auto-select LEDS_CLASS
> > > for JOYSTCK_XPAD_LEDS.
> > >
> >
> > I'd rather it depend on LEDS_CLASS (but properly). I believe I posted
> > a patch yesterday.
>
> Didn't see this as I am not subscribed to one of the input or joystick mailing lists
> (and didn't find any archive for that lists either).
> So today I have checked your input.git tree on git.kernel.org.
>
> Your patch (commit be1945c47248fa9c0a7cf4a04c1f4c32928656d2)
> works fine if you rename LED_CLASS to LEDS_CLASS ...
>
> So better fix that typo before your tree is pulled into Linus' tree.
> ;-)
>

Oops, thank you ;)

-- 
Dmitry