From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Cc: linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [HP7XX/PATCH] - HP720 Jornada Touchscreen (Updated, please use this one)
Date: Wed, 19 Sep 2007 16:46:52 -0400 [thread overview]
Message-ID: <d120d5000709191346w3fc0778ftb0db42d539146eb8@mail.gmail.com> (raw)
In-Reply-To: <20070919223138.1f0b79d1.Kristoffer.ericson@gmail.com>
On 9/20/07, Kristoffer Ericson <kristoffer.ericson@gmail.com> wrote:
> + if (jornada_ssp_inout(GETTOUCHSAMPLES == TXDUMMY)) {
Are you sure? Looks like paren is pisplaced.
> +
> + ret = request_irq(IRQ_GPIO9,
> + jornada720_ts_interrupt,
> + IRQF_DISABLED | IRQF_TRIGGER_RISING,
> + "HP7XX Touchscreen driver", jornada_ts);
> + if (ret) {
> + printk(KERN_INFO "HP7XX TS : Unable to aquire irq!\n");
> + goto failed2;
> + }
> +
> + if (input_register_device(input_dev))
> + goto failed2;
You will leak IRQ_GPIO9 if input_register_device fails.
Please do not forget adding Signed-off-by: to all of your patches so I
don;t have to hunt for them through old e-mails. Thanks!
--
Dmitry
prev parent reply other threads:[~2007-09-19 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 3:49 [HP7XX/PATCH] - HP720 Jornada Touchscreen (Updated, please use this one) Kristoffer Ericson
2007-09-19 19:19 ` Dmitry Torokhov
2007-09-20 5:31 ` Kristoffer Ericson
2007-09-19 20:46 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000709191346w3fc0778ftb0db42d539146eb8@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=kristoffer.ericson@gmail.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).