Re: Problem with appletouch driver in Linux version 2.6.23-rc7

["Dmitry Torokhov" <dmitry.torokhov@gmail.com>]

On 9/26/07, Soeren Sonnenburg <kernel@nn7.de> wrote:
>
> On Mon, 2007-09-24 at 15:22 +0200, Thomas Rohwer wrote:
> > Hello,
> >
> > > could you please re-send the patch? I for some reason have yet to see
> > > it ...
> >
> > here it is again, adressing also the comments from Dmitry.
>
> Thomas, Matthew and Dmitry,
>
> I think there is another bug in this. I mean whenever a mouse button is
> pressed or the mouse is moved the counter should be reset - no?
>
> Currently the idle counter is just increased...
>
> I mean shouldn't it be
>
> if (x || y || key)
>        dev->idlecount=0;
>
> if (!x && !y && !key)
> {
>        dev->idlecount++;
>        if (dev->idlecount == 10) {
>                dev->valid = 0;
>                schedule_work(&dev->work);
>        }
> }
>

Yes, I think you are right. I guess one could trigger an extra reset
by pressing the button repeatedly witout touching the pad. But because
we won't do reset while the button is pressed we'll never lose release
event.

I guess we want to fix it but it can wait for 2.6.24. A patch woudl be
appreciated.

Thanks!

-- 
Dmitry