From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: Problem with appletouch driver in Linux version 2.6.23-rc7 Date: Wed, 26 Sep 2007 16:13:00 -0400 Message-ID: References: <46F54D92.7000300@tng.de> <1190638998.12782.0.camel@localhost> <46F7BA08.6000201@tng.de> <1190836596.1359.33.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1190836596.1359.33.camel@localhost> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Soeren Sonnenburg Cc: Thomas Rohwer , linux-input@atrey.karlin.mff.cuni.cz, Matthew Garrett List-Id: linux-input@vger.kernel.org On 9/26/07, Soeren Sonnenburg wrote: > > On Mon, 2007-09-24 at 15:22 +0200, Thomas Rohwer wrote: > > Hello, > > > > > could you please re-send the patch? I for some reason have yet to see > > > it ... > > > > here it is again, adressing also the comments from Dmitry. > > Thomas, Matthew and Dmitry, > > I think there is another bug in this. I mean whenever a mouse button is > pressed or the mouse is moved the counter should be reset - no? > > Currently the idle counter is just increased... > > I mean shouldn't it be > > if (x || y || key) > dev->idlecount=0; > > if (!x && !y && !key) > { > dev->idlecount++; > if (dev->idlecount == 10) { > dev->valid = 0; > schedule_work(&dev->work); > } > } > Yes, I think you are right. I guess one could trigger an extra reset by pressing the button repeatedly witout touching the pad. But because we won't do reset while the button is pressed we'll never lose release event. I guess we want to fix it but it can wait for 2.6.24. A patch woudl be appreciated. Thanks! -- Dmitry