From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: Handling transition into suspend through keyboard driver Date: Tue, 9 Oct 2007 14:39:38 -0400 Message-ID: References: <20071008002510.d3ce4591.Kristoffer.ericson@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20071008002510.d3ce4591.Kristoffer.ericson@gmail.com> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Kristoffer Ericson Cc: linux-input-list List-Id: linux-input@vger.kernel.org Hi Kristoffer, On 10/8/07, Kristoffer Ericson wrote: > Greetings, > > Dmitry, Im implementing suspend for hp7xx currently. I've added EV_PWR to bitflags and linked so POWER_KEY gets reported correctly. > Is this the correct approach? > Yes, it is. Keyboard drivers sghoudl just emit proper events and we expect userspace to react on those properly. Look at corgi and spitz drivers. -- Dmitry