From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@atrey.karlin.mff.cuni.cz,
Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>
Subject: Re: [patch 1/8] m68k: Atari input drivers cleanup
Date: Mon, 15 Oct 2007 09:24:23 -0400 [thread overview]
Message-ID: <d120d5000710150624p25a87bb0k19e21b8bec914be2@mail.gmail.com> (raw)
In-Reply-To: <20071013123412.197946192@mail.of.borg>
Hi Geert,
On 10/13/07, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> m68k: Atari input drivers cleanup:
> - memleak on failed init/register of input devices fixed
> - correct keycodes table (Atari keycodes are almost, but not entirely, equal
> to Linux keycodes).
>
> Signed-off-by: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Looks much better, thank you.
>
> - input_register_device(atakbd_dev);
> + /* error check */
> + if (input_register_device(atakbd_dev)) {
> + input_free_device(atakbd_dev);
> + return -ENOMEM;
> + }
>
I'd be more happy if we returned real error reported by
input_register_device() instead of substituting it with -ENOMEM.
--
Dmitry
next prev parent reply other threads:[~2007-10-15 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071013123123.085686856@mail.of.borg>
2007-10-13 12:31 ` [patch 1/8] m68k: Atari input drivers cleanup Geert Uytterhoeven
2007-10-15 13:24 ` Dmitry Torokhov [this message]
2007-10-13 12:31 ` [patch 2/8] m68k: Atari keyboard ACIA driver cleanup Geert Uytterhoeven
2007-10-13 15:32 ` Andreas Schwab
2007-10-13 18:27 ` Geert Uytterhoeven
2007-10-15 13:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000710150624p25a87bb0k19e21b8bec914be2@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitz@biophys.uni-duesseldorf.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).