From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: Bryan Wu <cooloney.lkml@gmail.com>
Cc: bryan.wu@analog.com, Andrey Panin <pazke@donpac.ru>,
Roel Kluin <12o3l@tiscali.nl>,
"Ahmed S. Darwish" <darwish.07@gmail.com>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-joystick@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver
Date: Mon, 15 Oct 2007 13:40:42 -0400 [thread overview]
Message-ID: <d120d5000710151040n2dbea5cbt515d3df87d5d19ed@mail.gmail.com> (raw)
In-Reply-To: <386072610710151024s13e9c16qd7c974cde8000a9@mail.gmail.com>
On 10/15/07, Bryan Wu <cooloney.lkml@gmail.com> wrote:
> On 10/15/07, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> >
> > Completion is just not a good abstraction here... Please use work
> > abstraction and possibly a separate workqueue.
>
> Yes, I agree with you now, although I have a little concern about the
> possibility of big delay introduced by workqueue.
>
Having a separate workqueue should isolate the driver from users
hogging keventd. Otherwise the speed should be pretty much the same as
with a kthread.
>
> Thanks a lot for you kindly review.
> I will resend update patch later.
Thank you for not getting frustrated with all my change requests. Btw,
blackfin keypad driver is in my tree and should be in mainline once
Linus does the pull I requested.
--
Dmitry
next prev parent reply other threads:[~2007-10-15 17:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1192459625.6215.17.camel@roc-laptop>
2007-10-15 15:48 ` [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver Dmitry Torokhov
2007-10-15 17:24 ` Bryan Wu
2007-10-15 17:40 ` Dmitry Torokhov [this message]
2007-10-16 5:51 ` Bryan Wu
2007-10-16 16:53 ` Dmitry Torokhov
2007-10-15 18:27 ` Ahmed S. Darwish
2007-10-16 6:08 ` Bryan Wu
2007-10-16 16:40 ` Ahmed S. Darwish
2007-10-15 19:35 ` Jean Delvare
2007-10-15 14:47 Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000710151040n2dbea5cbt515d3df87d5d19ed@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=cooloney.lkml@gmail.com \
--cc=darwish.07@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-joystick@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@donpac.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).