From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver Date: Mon, 15 Oct 2007 13:40:42 -0400 Message-ID: References: <1192459625.6215.17.camel@roc-laptop> <386072610710151024s13e9c16qd7c974cde8000a9@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <386072610710151024s13e9c16qd7c974cde8000a9@mail.gmail.com> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Bryan Wu Cc: bryan.wu@analog.com, Andrey Panin , Roel Kluin <12o3l@tiscali.nl>, "Ahmed S. Darwish" , linux-input@atrey.karlin.mff.cuni.cz, linux-joystick@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Jean Delvare List-Id: linux-input@vger.kernel.org On 10/15/07, Bryan Wu wrote: > On 10/15/07, Dmitry Torokhov wrote: > > > > Completion is just not a good abstraction here... Please use work > > abstraction and possibly a separate workqueue. > > Yes, I agree with you now, although I have a little concern about the > possibility of big delay introduced by workqueue. > Having a separate workqueue should isolate the driver from users hogging keventd. Otherwise the speed should be pretty much the same as with a kthread. > > Thanks a lot for you kindly review. > I will resend update patch later. Thank you for not getting frustrated with all my change requests. Btw, blackfin keypad driver is in my tree and should be in mainline once Linus does the pull I requested. -- Dmitry