From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH] ACPI: Put button input devices in correct place in sysfs Date: Tue, 6 Nov 2007 15:47:13 -0500 Message-ID: References: <200711062051.59884.arvidjaar@mail.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200711062051.59884.arvidjaar@mail.ru> Content-Disposition: inline Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Andrey Borzenkov Cc: linux-acpi@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz, David Brownell List-Id: linux-input@vger.kernel.org Hi Andrey, On Nov 6, 2007 12:51 PM, Andrey Borzenkov wrote: > Properly set up parent on input device registered by the button driver. > Seems to be a popular topic today :) > > + input->cdev.dev = &device->dev; Please don't use cdev, but rather input_dev->dev.parent. cdev is going away soon. I sent a patch a couple of days ago to teh acpi list... -- Dmitry