From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: Herbert Valerio Riedel <hvr@gnu.org>
Cc: linux-input@vger.kernel.org, Paul Sokolovsky <pmiscml@gmail.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Philip Blundell <philb@gnu.org>
Subject: Re: [PATCH,RFC] Input: gpio-keys - request and configure GPIOs
Date: Fri, 16 Nov 2007 08:38:11 -0500 [thread overview]
Message-ID: <d120d5000711160538u6f629e34h9465a880f09be49c@mail.gmail.com> (raw)
In-Reply-To: <1195212830-9137-1-git-send-email-hvr@gnu.org>
Hi,
On Nov 16, 2007 6:33 AM, Herbert Valerio Riedel <hvr@gnu.org> wrote:
> Currently, gpio_keys.c assumes the GPIOs to be already properly configured;
> this patch changes gpio-keys to perform explicit calls to gpio_request() and
> gpio_configure_input().
>
> This matches the behaviour of leds-gpio.
>
Makes sense from where I sit but let's see what guys who actually use
the module say... ;)
--
Dmitry
next prev parent reply other threads:[~2007-11-16 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 11:33 [PATCH,RFC] Input: gpio-keys - request and configure GPIOs Herbert Valerio Riedel
2007-11-16 11:50 ` Herbert Valerio Riedel
2007-11-16 13:38 ` Dmitry Torokhov [this message]
2007-11-16 14:02 ` pHilipp Zabel
2007-11-16 14:15 ` Herbert Valerio Riedel
2007-11-16 14:09 ` Herbert Valerio Riedel
2007-11-16 14:19 ` pHilipp Zabel
2007-11-21 17:13 ` Herbert Valerio Riedel
2007-11-21 19:44 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000711160538u6f629e34h9465a880f09be49c@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=hvr@gnu.org \
--cc=linux-input@vger.kernel.org \
--cc=philb@gnu.org \
--cc=philipp.zabel@gmail.com \
--cc=pmiscml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).