From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH,RFC] Input: gpio-keys - request and configure GPIOs Date: Fri, 16 Nov 2007 08:38:11 -0500 Message-ID: References: <1195212830-9137-1-git-send-email-hvr@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from nf-out-0910.google.com ([64.233.182.184]:38696 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757580AbXKPNiO (ORCPT ); Fri, 16 Nov 2007 08:38:14 -0500 Received: by nf-out-0910.google.com with SMTP id g13so820556nfb for ; Fri, 16 Nov 2007 05:38:12 -0800 (PST) In-Reply-To: <1195212830-9137-1-git-send-email-hvr@gnu.org> Content-Disposition: inline Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Herbert Valerio Riedel Cc: linux-input@vger.kernel.org, Paul Sokolovsky , Philipp Zabel , Philip Blundell Hi, On Nov 16, 2007 6:33 AM, Herbert Valerio Riedel wrote: > Currently, gpio_keys.c assumes the GPIOs to be already properly configured; > this patch changes gpio-keys to perform explicit calls to gpio_request() and > gpio_configure_input(). > > This matches the behaviour of leds-gpio. > Makes sense from where I sit but let's see what guys who actually use the module say... ;) -- Dmitry