From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: Dmitry Baryshkov <dbaryshkov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] Tosa keyboard support
Date: Fri, 11 Jan 2008 09:56:06 -0500 [thread overview]
Message-ID: <d120d5000801110656n1e65f4amf743a8f90183cc09@mail.gmail.com> (raw)
In-Reply-To: <fljpft$nc9$1@ger.gmane.org>
Hi,
On Jan 3, 2008 6:01 PM, Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
>
> >
> > Also, I'd put these defines rigth in tosakbd.c.
>
> The TOSA_KEY_RECORD and SYNC are used inside arch/arm/mach-pxa/tosa.c
> (for gpio-keys declaration). So I would prefer to place all such defines here.
> When the Kdrive would be fixed, I would drop KEY_RECORD and happily move
> that defines to tosakbd.c
>
Ok, fair enough. Because driver touches arch-specific arm parts it
does not apply cleanly to my tree. I think the best way would be to
merge it through arm side, this will minimize merge efforts Feel free
to add:
Acked-by: Dmitry Torokhov <dtor@mail.ru>
--
Dmitry
next prev parent reply other threads:[~2008-01-11 14:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-23 23:29 [PATCH] Tosa keyboard support Dmitry Baryshkov
2008-01-03 16:51 ` Dmitry Torokhov
2008-01-03 23:01 ` Dmitry Baryshkov
2008-01-03 23:08 ` Dmitry Baryshkov
2008-01-11 14:56 ` Dmitry Torokhov [this message]
2008-01-11 16:38 ` Dmitry Baryshkov
2008-01-11 20:52 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2007-12-11 15:23 Dmitry Baryshkov
2007-12-11 15:38 ` Dmitry Baryshkov
2007-12-16 10:29 ` Russell King - ARM Linux
2007-12-16 10:52 ` Dmitry
2007-12-16 10:51 ` Dmitry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000801110656n1e65f4amf743a8f90183cc09@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).