From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Torokhov" Subject: Re: [PATCH] Tosa keyboard support Date: Fri, 11 Jan 2008 09:56:06 -0500 Message-ID: References: <20071223232914.GA28932@doriath.ww600.siemens.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from hu-out-0506.google.com ([72.14.214.236]:55299 "EHLO hu-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756100AbYAKO4I (ORCPT ); Fri, 11 Jan 2008 09:56:08 -0500 Received: by hu-out-0506.google.com with SMTP id 19so451700hue.21 for ; Fri, 11 Jan 2008 06:56:06 -0800 (PST) In-Reply-To: Content-Disposition: inline Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Baryshkov Cc: linux-input@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk Hi, On Jan 3, 2008 6:01 PM, Dmitry Baryshkov wrote: > > > > > Also, I'd put these defines rigth in tosakbd.c. > > The TOSA_KEY_RECORD and SYNC are used inside arch/arm/mach-pxa/tosa.c > (for gpio-keys declaration). So I would prefer to place all such defines here. > When the Kdrive would be fixed, I would drop KEY_RECORD and happily move > that defines to tosakbd.c > Ok, fair enough. Because driver touches arch-specific arm parts it does not apply cleanly to my tree. I think the best way would be to merge it through arm side, this will minimize merge efforts Feel free to add: Acked-by: Dmitry Torokhov -- Dmitry