Re: [PATCH] Tosa keyboard support

["Dmitry Torokhov" <dmitry.torokhov@gmail.com>]

On Jan 11, 2008 11:38 AM, Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
> Hi,
>
>
> Dmitry Torokhov wrote:
>
> > Hi,
> >
> > On Jan 3, 2008 6:01 PM, Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
> >>
> >>
> >> > Also, I'd put these defines rigth in tosakbd.c.
> >>
> >> The TOSA_KEY_RECORD and SYNC are used inside arch/arm/mach-pxa/tosa.c
> >> (for gpio-keys declaration). So I would prefer to place all such
> >> defines here. When the Kdrive would be fixed, I would drop KEY_RECORD
> >> and happily move that defines to tosakbd.c
> >>
> >>
> > Ok, fair enough. Because driver touches arch-specific arm parts it does
> > not apply cleanly to my tree. I think the best way would be to merge it
> > through arm side, this will minimize merge efforts Feel free to add:
>
> Strange. The patch is against 2.6.24-rc7 and applies cleanly to both
> for-linus and master branches of .../dtor/input.git

Hmm, I think the version I originally tried did not... Anyway, my
concern is that when flood gates for .25 are opened there will be alot
of changes in PXA land. However changes to input side are trivial
(Kconfig and Makefile) and are resolved much easier so if you
coordinate with Russel it will work much better.

> > Acked-by: Dmitry Torokhov <dtor@mail.ru>
>
> Russell, do I need to resent patch?
>

-- 
Dmitry