From: Vicki Pfau <vi@endrift.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lyude Paul <lyude@redhat.com>
Cc: Michael Cullen <michael@michaelcullen.name>,
Marcos Alano <marcoshalano@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: xpad - fix PowerA EnWired Controller guide button
Date: Mon, 27 Feb 2023 16:32:26 -0800 [thread overview]
Message-ID: <d153e498-fda9-21dc-6b4c-c6b45a1edd76@endrift.com> (raw)
In-Reply-To: <Y/pS+NAqCwdQNJNQ@google.com>
Hi Dmitry,
On 2/25/23 10:27, Dmitry Torokhov wrote:
> Hi Lyude,
>
> On Sat, Feb 25, 2023 at 02:14:27AM +0100, Lyude Paul wrote:
>> Poke, Dmitry - any chance we could get this pushed?
>
> I was waiting for Vicki to respond to Mattijs' comments...
>
> Thanks.
>
I'm a little confused as to what's happened here. This appears to be the thread for the v1 of this patch, but the v2 appeared later in a separate series (https://lore.kernel.org/linux-input/20230203022758.3982393-1-vi@endrift.com/T/#m98b35653c34a180e08cebb63b43b3690943f6e77) that was reviewed already. It moves the check into a separate function that will wind up properly freeing the URB if it fails. I tried moving it directly into probe, but that broke resume; it works properly when put in this function.
Vicki
prev parent reply other threads:[~2023-02-28 0:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 22:12 [PATCH] Input: xpad - fix PowerA EnWired Controller guide button Vicki Pfau
2022-10-14 13:00 ` Mattijs Korpershoek
2023-02-25 1:14 ` Lyude Paul
2023-02-25 18:27 ` Dmitry Torokhov
2023-02-28 0:32 ` Vicki Pfau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d153e498-fda9-21dc-6b4c-c6b45a1edd76@endrift.com \
--to=vi@endrift.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=marcoshalano@gmail.com \
--cc=michael@michaelcullen.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).