From: Caleb Connolly <caleb@connolly.tech>
To: Pavel Machek <pavel@ucw.cz>, Gergo Koteles <soyer@irl.hu>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: add tri-state-key
Date: Sun, 12 Feb 2023 01:58:33 +0000 [thread overview]
Message-ID: <d1959211-bf33-f4fd-01a8-91dcd247aa70@connolly.tech> (raw)
In-Reply-To: <Y+fE7gIMD4BDCffy@duo.ucw.cz>
On 11/02/2023 16:40, Pavel Machek wrote:
> Hi!
>
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -52,6 +52,43 @@ key-vol-up {
>> };
>> };
>>
>> + tri-state-key {
>> + compatible = "gpio-keys";
>> + label = "Tri-state key";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&tri_state_key_default>;
>> + state-top {
>> + label = "Tri-state key top";
>
> "top/middle" is not too useful. Do we need the label at all? If so,
> should it say "loud/vibrations only/mute"?
"mute", "vibrate" and "ring" sound good to me.
Although it would be nice if users can easily map the physical key
position to the action when viewing the input device or remapping the
key in userspace.
Do you have any ideas or recommendations on how to do this?
>
> BR,
> Pavel
--
Kind Regards,
Caleb
next prev parent reply other threads:[~2023-02-12 1:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 23:25 [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: add tri-state-key Gergo Koteles
2023-02-10 11:33 ` Krzysztof Kozlowski
2023-02-10 13:45 ` Gergo Koteles
2023-02-10 13:53 ` Konrad Dybcio
2023-02-11 16:40 ` Pavel Machek
2023-02-12 1:58 ` Caleb Connolly [this message]
2023-02-16 3:32 ` Gergo Koteles
2023-02-19 15:30 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1959211-bf33-f4fd-01a8-91dcd247aa70@connolly.tech \
--to=caleb@connolly.tech \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=soyer@irl.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).