From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4A412233B for ; Fri, 26 Jan 2024 19:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706297127; cv=none; b=cHdtlQmMEykuuiwJ2XKCOZaoEKOqSjIqqexVPSqhPWSmigQgbcSfGMQOGBdMCH2VDc/x45nke6CGIzhzIiZUNsIX7m0QYYVPyg2DpPHKyCI4ArywpNOQjeXSwhipCezqmv/fjo7qaEWYKYprWtQU7FtidjhdrvqTK6P9BEJZtM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706297127; c=relaxed/simple; bh=8RvrO6y0/Of68/2+jUaQkLUjJNzaixet1pA07PR0cp0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LH3jbGk0Cu4cJ+OCD5sIxIVKGR1+4qfOhHTbqN3pAvl04X8Aqgpo33Mxob30DMyJsDYcaDArDaCXMHWBZihtEFR6+flldQ6FcEWPY/hdZZgT6XVqr1u0rgz9AGO06zdNS85WsuHXguX4enGxHWqrFdeJPgyntUNCNgn0e1KwbeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bd+tjS0D; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bd+tjS0D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706297125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9BwPJ3hvI/qWKIxSwUd8kfeZg8oeRu3IC468fyX+vyo=; b=bd+tjS0DthZS7v5buSpmhBUNIfmLhgDl186tU8HWyT4Wis+SAL/2mw+sq5XRMcljDkCQo2 IyLHsrG0WTlsNLmAZowydoD6FGK6EGI/7cOkTAPw7OOa7BCA/6ktZ8gXWkLlqCnn17q+jf 0tGYEy7rlI9b3Y/pR1PUVYqCr6HU5fc= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-cvD6ILSjPpe1eVg-KBk6HQ-1; Fri, 26 Jan 2024 14:25:23 -0500 X-MC-Unique: cvD6ILSjPpe1eVg-KBk6HQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a336006ef27so77630666b.0 for ; Fri, 26 Jan 2024 11:25:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706297122; x=1706901922; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9BwPJ3hvI/qWKIxSwUd8kfeZg8oeRu3IC468fyX+vyo=; b=WSLbUc8ye6NwFXV7KnTWkaMeUwLZmXiM7Ojlx0rRZEsH27yNHTthniAvXdgWndw0OH iD6n8X63OHQmjUtiHOPAyBltrFT4x1MfbXY7TrILjA0JrJujac31sbn9WxU5aV+m5hOU /0s/ljD9zaDO9NFEMDkFq3iZ5ZIPO1iv4P0rx7+bgMcGtal/F+khuWyVvv5GBv5Vh4PG BVCKyTlO990FAQ3ddSzUKInrWEaZ0kMIFL4FzpiuTFCNxI/SWTi55F8QrZ1pmzZgwmqO nU2v6et8skWJnESascS89/lcowZ3ql0/tiWOgJwL5amHsLL9tpCBiUDsC5lQDoyATn6C xb+Q== X-Gm-Message-State: AOJu0YyF3tmbhhj87XY5xXgTLc+vsYO5IIx0w+eKONIkSEWu4hBigOkM 8QPGdqQbQM9tdlm5rtN3r4tiI0LKjOfwuzBXWazTOXgtlcSvJbfsA1AIWucy/I36hIdAHN7wnJT N2WACS2njk4illioGotTLJMSLCGdB0Ten0qliTh57jEwWznn2DNEo/yqIvfMX X-Received: by 2002:a17:907:d40f:b0:a32:6050:46eb with SMTP id vi15-20020a170907d40f00b00a32605046ebmr2342013ejc.23.1706297122304; Fri, 26 Jan 2024 11:25:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGH7koZ3GtAHLsUDuZmgVG/7afQQStoYjkOG4elT+L0C6gW2E+7RHwF8ftfXVXnrcCaZieTBQ== X-Received: by 2002:a17:907:d40f:b0:a32:6050:46eb with SMTP id vi15-20020a170907d40f00b00a32605046ebmr2342001ejc.23.1706297122033; Fri, 26 Jan 2024 11:25:22 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id jt6-20020a170906dfc600b00a2d1b0c7b80sm931908ejc.57.2024.01.26.11.25.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 11:25:21 -0800 (PST) Message-ID: Date: Fri, 26 Jan 2024 20:25:20 +0100 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/platform/x86/touchscreen_dmi.c: Add touch config Content-Language: en-US, nl To: Phoenix Chen Cc: ilpo.jarvinen@linux.intel.com, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240126095308.5042-1-asbeltogf@gmail.com> From: Hans de Goede In-Reply-To: <20240126095308.5042-1-asbeltogf@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 1/26/24 10:53, Phoenix Chen wrote: > Added touch screen info for TECLAST X16 Plus tablet. > > Signed-off-by: Phoenix Chen Thank you for your patch/series, I've applied this patch (series) to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans And thank you for also adding the embedded_fw data so that is will work out of the box for end users. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/x86/touchscreen_dmi.c | 35 ++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c > index 0c6733772698..7aee5e9ff2b8 100644 > --- a/drivers/platform/x86/touchscreen_dmi.c > +++ b/drivers/platform/x86/touchscreen_dmi.c > @@ -944,6 +944,32 @@ static const struct ts_dmi_data teclast_tbook11_data = { > .properties = teclast_tbook11_props, > }; > > +static const struct property_entry teclast_x16_plus_props[] = { > + PROPERTY_ENTRY_U32("touchscreen-min-x", 8), > + PROPERTY_ENTRY_U32("touchscreen-min-y", 14), > + PROPERTY_ENTRY_U32("touchscreen-size-x", 1916), > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1264), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), > + PROPERTY_ENTRY_STRING("firmware-name", "gsl3692-teclast-x16-plus.fw"), > + PROPERTY_ENTRY_U32("silead,max-fingers", 10), > + PROPERTY_ENTRY_BOOL("silead,home-button"), > + { } > +}; > + > +static const struct ts_dmi_data teclast_x16_plus_data = { > + .embedded_fw = { > + .name = "silead/gsl3692-teclast-x16-plus.fw", > + .prefix = { 0xf0, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00 }, > + .length = 43560, > + .sha256 = { 0x9d, 0xb0, 0x3d, 0xf1, 0x00, 0x3c, 0xb5, 0x25, > + 0x62, 0x8a, 0xa0, 0x93, 0x4b, 0xe0, 0x4e, 0x75, > + 0xd1, 0x27, 0xb1, 0x65, 0x3c, 0xba, 0xa5, 0x0f, > + 0xcd, 0xb4, 0xbe, 0x00, 0xbb, 0xf6, 0x43, 0x29 }, > + }, > + .acpi_name = "MSSL1680:00", > + .properties = teclast_x16_plus_props, > +}; > + > static const struct property_entry teclast_x3_plus_props[] = { > PROPERTY_ENTRY_U32("touchscreen-size-x", 1980), > PROPERTY_ENTRY_U32("touchscreen-size-y", 1500), > @@ -1612,6 +1638,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_SKU, "E5A6_A1"), > }, > }, > + { > + /* Teclast X16 Plus */ > + .driver_data = (void *)&teclast_x16_plus_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "TECLAST"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Default string"), > + DMI_MATCH(DMI_PRODUCT_SKU, "D3A5_A1"), > + }, > + }, > { > /* Teclast X3 Plus */ > .driver_data = (void *)&teclast_x3_plus_data,