From: Markus Elfring <Markus.Elfring@web.de>
To: "Leo L. Schwab" <ewhac@ewhac.org>, linux-input@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Hans de Goede <hansg@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Kate Hsuan <hpa@redhat.com>
Subject: Re: [PATCH] HID: lg-g15 - Add support for Logitech G13.
Date: Mon, 11 Aug 2025 19:10:46 +0200 [thread overview]
Message-ID: <d37e7ccd-1d5d-4237-8a7e-a0eb10ec069d@web.de> (raw)
In-Reply-To: <20250810225617.1006272-2-ewhac@ewhac.org>
…
> +++ b/drivers/hid/hid-lg-g15.c
…
> +static int lg_g13_kbd_led_set(struct led_classdev *led_cdev, enum led_brightness brightness)
> +{
…
> + mutex_lock(&g15->mutex);
> + ret = lg_g13_kbd_led_write(g15, g15_led, brightness);
> + mutex_unlock(&g15->mutex);
> +
> + return ret;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&g15->mutex);”?
https://elixir.bootlin.com/linux/v6.16/source/include/linux/mutex.h#L225
Regards,
Markus
next prev parent reply other threads:[~2025-08-11 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-10 22:56 [PATCH] HID: lg-g15 - Add support for Logitech G13 Leo L. Schwab
2025-08-11 17:00 ` Markus Elfring
2025-08-12 6:51 ` Leo L. Schwab
2025-08-11 17:10 ` Markus Elfring [this message]
2025-08-12 0:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d37e7ccd-1d5d-4237-8a7e-a0eb10ec069d@web.de \
--to=markus.elfring@web.de \
--cc=bentiss@kernel.org \
--cc=ewhac@ewhac.org \
--cc=hansg@kernel.org \
--cc=hpa@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox