From: Marek Vasut <marex@denx.de>
To: Frank Li <Frank.Li@nxp.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Hasemeyer <markhas@chromium.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml
Date: Fri, 16 Aug 2024 18:36:03 +0200 [thread overview]
Message-ID: <d42f0f37-9c17-4daa-a807-23e8b5c5668b@denx.de> (raw)
In-Reply-To: <20240816161300.128269-1-Frank.Li@nxp.com>
On 8/16/24 6:12 PM, Frank Li wrote:
[...]
> + ti,debounce-max:
> + deprecated: true
> + $ref: /schemas/types.yaml#/definitions/uint16
> + description: Max number of additional readings per sample.
> +
> + ti,debounce-rep:
> + $ref: /schemas/types.yaml#/definitions/uint16
> + description:
> + Additional consecutive good readings required after the first two.
Should the description: and the description text be on the same line ?
Or separate by newline ? Or should it use description: | and then a
newline ?
It would be good to be consistent about this.
> + ti,debounce-tol:
> + $ref: /schemas/types.yaml#/definitions/uint16
> + description: Tolerance used for filtering.
> +
> + ti,hsync-gpios:
> + description:
> + GPIO line to poll for hsync
Please make sure each sentence ends with a fullstop '.' .
Thanks !
prev parent reply other threads:[~2024-08-16 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 16:12 [PATCH v3 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml Frank Li
2024-08-16 16:36 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d42f0f37-9c17-4daa-a807-23e8b5c5668b@denx.de \
--to=marex@denx.de \
--cc=Frank.Li@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markhas@chromium.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).