From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9683C433EF for ; Mon, 18 Apr 2022 12:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236344AbiDRMep (ORCPT ); Mon, 18 Apr 2022 08:34:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239225AbiDRMcj (ORCPT ); Mon, 18 Apr 2022 08:32:39 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C188525EAA for ; Mon, 18 Apr 2022 05:24:22 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id lc2so26498614ejb.12 for ; Mon, 18 Apr 2022 05:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=5BNPomPjSt5hiIea69EjTytPpEqikhMJXfLRqSI0kqc=; b=I5SuOIQtfj+q49dWAfkSqB3QEoGkcQfwsNlbTI9LRwxKGBca6C8FMO+RPcsStXcouw 2FsU+EMejcQ0Xq1EFdGgKf/N0JaDRNSS6bl0roXE2RYiN5oKXz8I6gVyJfznys9CUYX8 +CoXwOuhTicBgujPYcRgqJdLf7vzTFMmxZd6d7Hgji5Z7cuQcx5Lyjj14s7fbAO7JEzb DNDK4/EVWvedwBSd1WFiEqgWHULj7pdR4Hl2iE1K0m1Vgbd0rO1/L/frFwRlQzFaNgAA QAce4D+vkqhUF8XTQcjzsAPhK7Gh33ZJmRF2v24MjS1kRSmbU2jYVlHOo2ZL7hzsz/Zc NB/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5BNPomPjSt5hiIea69EjTytPpEqikhMJXfLRqSI0kqc=; b=4mSudkIJNFpK6G1BbPbX+3tFTqrFjccS2VggXA3oDv0XAtnpDvM9rVxPFKT1gfOo7+ PP1x+dWrsWpKurIJmnL7b0THdewZM/pC1Q384hrcuUoZKxzHuN0R8flNNX8Uvh+bUWXm C65SfPJerPsBciG5IfXXsofyz7Gn4FfG3GeUh/AxssyGzzN+iwsm7sn7wwTdo/oKfD/y grFmHciRT/w2fQy6H0Ya6TqeTvq6pFQ8px11hPf0CQDfq39l6ooCDgi/m30le0OEMmvp aSq5lfG5r2n+GCJhqgLOgICu+IYRY4Lh6FYQcmJw+6NwEoQMrTrJOw2l4+a6X3jAKLHs Yc9A== X-Gm-Message-State: AOAM531ylH0NIIEJwgU157YSP/IOvL4CES/xRzmGTO627f4J6MpbRM3Q lxBjpB0AXDgfJDeiJmcNcbQtODRNyRZvZA== X-Google-Smtp-Source: ABdhPJzA+mjTWUhOE3zIGZp8dEO8EaZ9s5olb+oYT5/uf26kP4FWKUquYw+4VYBh+7qW1k0QWLNFNg== X-Received: by 2002:a17:907:a40b:b0:6da:b4a1:33fa with SMTP id sg11-20020a170907a40b00b006dab4a133famr8628973ejc.22.1650284661044; Mon, 18 Apr 2022 05:24:21 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id v21-20020a1709064e9500b006e8973a14d0sm4596498eju.174.2022.04.18.05.24.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Apr 2022 05:24:20 -0700 (PDT) Message-ID: Date: Mon, 18 Apr 2022 14:24:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/4] dt-bindings: input: Add the PinePhone keyboard binding Content-Language: en-US To: Samuel Holland , Dmitry Torokhov , linux-input@vger.kernel.org Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , Ondrej Jirman , linux-kernel@vger.kernel.org References: <20220417021633.56127-1-samuel@sholland.org> <20220417021633.56127-2-samuel@sholland.org> From: Krzysztof Kozlowski In-Reply-To: <20220417021633.56127-2-samuel@sholland.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 17/04/2022 04:16, Samuel Holland wrote: (...) > +properties: > + compatible: > + const: pine64,pinephone-keyboard > + > + reg: > + const: 0x15 > + > + interrupts: > + maxItems: 1 > + > + vbat-supply: > + description: Supply for the keyboard MCU > + > + wakeup-source: true > + > + i2c-bus: Generic node names, so just "i2c". > + $ref: /schemas/i2c/i2c-controller.yaml# > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false You do not include any other schema at this level, so this should be additionalProperties:false. > + > +examples: > + - | > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + keyboard@15 { > + compatible = "pine64,pinephone-keyboard"; > + reg = <0x15>; > + interrupt-parent = <&r_pio>; > + interrupts = <0 12 IRQ_TYPE_EDGE_FALLING>; /* PL12 */ > + > + i2c-bus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + charger@75 { > + reg = <0x75>; > + }; > + }; > + }; > + }; Best regards, Krzysztof