From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 400DBC77B73 for ; Tue, 30 May 2023 13:33:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229449AbjE3Ndb convert rfc822-to-8bit (ORCPT ); Tue, 30 May 2023 09:33:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231147AbjE3Nd3 (ORCPT ); Tue, 30 May 2023 09:33:29 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F01E1F0; Tue, 30 May 2023 06:33:27 -0700 (PDT) X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net Received: by mail.gandi.net (Postfix) with ESMTPSA id 2DF431C0013; Tue, 30 May 2023 13:33:25 +0000 (UTC) Message-ID: Subject: Re: [PATCH] input: Add new keyboard backlight control keys to match modern notebooks From: Bastien Nocera To: Werner Sembach , Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 30 May 2023 15:33:25 +0200 In-Reply-To: <20230530110550.18289-1-wse@tuxedocomputers.com> References: <20230530110550.18289-1-wse@tuxedocomputers.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.0 (3.48.0-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Tue, 2023-05-30 at 13:05 +0200, Werner Sembach wrote: > The old three KEY_KBDILLUM* keycodes don't reflect the current > situation > modern notebooks anymore. Especially the ones with RGB keyboards. > > e.g. > - Clevo NL50NU has a toggle, an up, a down and a color-cycle key > - TongFang PH4ARX1 doesn't have a toggle key, but one that cycles > through >   off, half-brightness, and full-brightness. > > Also, on some devices these keys are already implemented in firmware. > It > would still be nice if there is a way to let userspace know when one > of > these keys is pressed to display the OSD, but don't advice it to > actually > do anything. This is the intended purpose of the KEY_KBDILLUMCHANGE > define. > > Signed-off-by: Werner Sembach Can you please point to the user-space patches (or issues filed) that would integrate the support for those keycodes, and make the key presses do something? Has anyone tested that those keycodes are fit for purpose when mixed with other brightness changes that don't happen through key presses? > --- >  include/uapi/linux/input-event-codes.h | 4 ++++ >  1 file changed, 4 insertions(+) > > diff --git a/include/uapi/linux/input-event-codes.h > b/include/uapi/linux/input-event-codes.h > index 022a520e31fc2..05287bf9a77f7 100644 > --- a/include/uapi/linux/input-event-codes.h > +++ b/include/uapi/linux/input-event-codes.h > @@ -803,6 +803,10 @@ >  #define BTN_TRIGGER_HAPPY39            0x2e6 >  #define BTN_TRIGGER_HAPPY40            0x2e7 >   > +#define KEY_KBDILLUMCYCLE              0x2e8 > +#define KEY_KBDILLUMCOLORCYCLE         0x2e9 > +#define KEY_KBDILLUMCHANGE             0x2ea > + >  /* We avoid low common keys in module aliases so they don't get > huge. */ >  #define KEY_MIN_INTERESTING    KEY_MUTE >  #define KEY_MAX                        0x2ff