From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Aaron Lu <aaron.lu@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] Input: gpio_keys_polled - always use gpiod_get_value_cansleep
Date: Thu, 20 Oct 2016 11:00:03 +0200 [thread overview]
Message-ID: <d6b25397-8c90-d40d-c60c-0087f30b7c03@redhat.com> (raw)
In-Reply-To: <20161019234332.GA15459@dtor-ws>
Hi,
On 20-10-16 01:43, Dmitry Torokhov wrote:
> On Wed, Oct 19, 2016 at 04:41:07PM -0700, Dmitry Torokhov wrote:
>> It does not matter if given GPIO may sleep or not when reading state,
>> polling is always done in a non-atomic context, so we should always
>> be able to simply use gpiod_get_value_cansleep().
>>
>> Also let's note in the logs when we fail to read gpio state.
>>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> ---
>> drivers/input/keyboard/gpio_keys_polled.c | 21 ++++++++++-----------
>> 1 file changed, 10 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c
>> index daef8ea..3c79158 100644
>> --- a/drivers/input/keyboard/gpio_keys_polled.c
>> +++ b/drivers/input/keyboard/gpio_keys_polled.c
>> @@ -34,7 +34,6 @@ struct gpio_keys_button_data {
>> int last_state;
>> int count;
>> int threshold;
>> - int can_sleep;
>> };
>>
>> struct gpio_keys_polled_dev {
>> @@ -76,16 +75,17 @@ static void gpio_keys_polled_check_state(struct input_polled_dev *dev,
>> {
>> int state;
>>
>> - if (bdata->can_sleep)
>> - state = !!gpiod_get_value_cansleep(bdata->gpiod);
>> - else
>> - state = !!gpiod_get_value(bdata->gpiod);
>> -
>> - gpio_keys_button_event(dev, button, state);
>> + state = gpiod_get_value_cansleep(bdata->gpiod);
>> + if (unlikely(state < 0)) {
>> + dev_err(input->dev.parent,
>
> Umm, this should have been dev->input->dev.parent
With that fixed this patch looks good to me and is:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>
>> + "failed to get gpio state: %d\n", state);
>> + } else {
>> + gpio_keys_button_event(dev, button, state);
>>
>> - if (state != bdata->last_state) {
>> - bdata->count = 0;
>> - bdata->last_state = state;
>> + if (state != bdata->last_state) {
>> + bdata->count = 0;
>> + bdata->last_state = state;
>> + }
>> }
>> }
>>
>> @@ -341,7 +341,6 @@ static int gpio_keys_polled_probe(struct platform_device *pdev)
>> }
>> }
>>
>> - bdata->can_sleep = gpiod_cansleep(bdata->gpiod);
>> bdata->last_state = -1;
>> bdata->threshold = DIV_ROUND_UP(button->debounce_interval,
>> pdata->poll_interval);
>> --
>> 2.8.0.rc3.226.g39d4020
>>
>>
>> --
>> Dmitry
>
next prev parent reply other threads:[~2016-10-20 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 23:41 [PATCH] Input: gpio_keys_polled - always use gpiod_get_value_cansleep Dmitry Torokhov
2016-10-19 23:43 ` Dmitry Torokhov
2016-10-20 9:00 ` Hans de Goede [this message]
2016-10-20 10:45 ` Mika Westerberg
2016-10-20 21:53 ` Dmitry Torokhov
2016-10-20 12:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6b25397-8c90-d40d-c60c-0087f30b7c03@redhat.com \
--to=hdegoede@redhat.com \
--cc=aaron.lu@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).