Linux Input/HID development
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Sriman Achanta <srimanachanta@gmail.com>,
	Jiri Kosina <jikos@kernel.org>,
	 Benjamin Tissoires	 <bentiss@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Simon Wood <simon@mungewell.org>,
	Christian Mayer <git@mayer-bgk.de>
Subject: Re: [PATCH v6 0/9] HID: steelseries: split out Arctis driver and add Nova 5X/Nova 7 support
Date: Fri, 10 Jul 2026 14:02:08 +0200	[thread overview]
Message-ID: <d77b5dc879741958390232cd1a5d04718d33d9d0.camel@hadess.net> (raw)
In-Reply-To: <20260709032316.1908460-1-68172138+srimanachanta@users.noreply.github.com>

Hey Sriman,

I won't have time to review the patchset this week, but I've created a
test kernel for Fedora 44 users, which should stay available for about
a week (IIRC).

https://koji.fedoraproject.org/koji/taskinfo?taskID=147618251

I'll try to send my review next week.

Regards

On Wed, 2026-07-08 at 23:23 -0400, Sriman Achanta wrote:
> From: Sriman Achanta <srimanachanta@gmail.com>
> 
> This series moves the SteelSeries Arctis headset support out of
> hid-steelseries.c into its own module, reworks it around a per-model
> device_info table, hardens the battery power-supply lifetime, adds an
> asynchronous status interface, and finally adds support for the
> Arctis
> Nova 5X and Nova 7 families. After the split, hid-steelseries.c is
> left
> handling only the SRW-S1 racing wheel.
> 
> Changes since v5:
>  - Nova: rename the Gen2-only parse function and device_info to
>    steelseries_arctis_nova_{parse_status,info} now that they are also
>    used by the Nova 5X and the 2026 refresh, not just Gen2.
>  - Nova: add device IDs and a device_info for the original (pre-Gen2)
>    Arctis Nova 7 family. It answers the same 0xb0/0xb7/0xb9/0xbb
> status
>    opcodes on the same interfaces as Gen2, but reports battery
> capacity
>    as a discrete 0-4 level rather than a raw percentage, so it gets
> its
>    own parse function that maps the level through
>    steelseries_map_capacity() instead of using it directly.
>  - Nova: add the Arctis Nova 5X, which shares the Gen2/2026 protocol.
>  - hid-ids.h: fix a whitespace-only bug where the new Nova 5X macro
> was
>    space-aligned instead of tab-aligned.
>  - Rebased on current master.
> 
> The Nova 5X protocol was verified against hardware by
> sp4m.an.joker@gmail.com, and the original Nova 7 protocol was
> verified
> against hardware by colin@1101b.com. Thanks to both for testing. I
> previously ommited other devices in the v4 patch series due to being
> unable to verify.
> 
> Sriman Achanta (9):
>   HID: steelseries: Fix ARCTIS_1_X device mislabeling
>   HID: steelseries: Split Arctis headset driver into separate module
>   HID: steelseries: Inline and simplify SRWS1 wheel driver
>   HID: steelseries: Refactor Arctis driver to use device_info
> framework
>   HID: steelseries: Report POWER_SUPPLY_STATUS_FULL when full
>   HID: steelseries: Correct Arctis 9 battery calibration range
>   HID: steelseries: Manage battery lifetime with refcounting
>   HID: steelseries: Add async status interface support
>   HID: steelseries: Add support for Arctis Nova 5X and Nova 7
> families
> 
>  drivers/hid/Makefile                 |   2 +-
>  drivers/hid/hid-ids.h                |  18 +-
>  drivers/hid/hid-quirks.c             |  16 +-
>  drivers/hid/hid-steelseries-arctis.c | 718
> +++++++++++++++++++++++++++
>  drivers/hid/hid-steelseries.c        | 406 +--------------
>  5 files changed, 759 insertions(+), 401 deletions(-)
>  create mode 100644 drivers/hid/hid-steelseries-arctis.c
> 
> 
> base-commit: 7404ce51637231382873d0b55edabc2f3b841a9d

      parent reply	other threads:[~2026-07-10 12:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  3:23 [PATCH v6 0/9] HID: steelseries: split out Arctis driver and add Nova 5X/Nova 7 support Sriman Achanta
2026-07-09  3:23 ` [PATCH v6 1/9] HID: steelseries: Fix ARCTIS_1_X device mislabeling Sriman Achanta
2026-07-09  3:36   ` sashiko-bot
2026-07-09  3:23 ` [PATCH v6 2/9] HID: steelseries: Split Arctis headset driver into separate module Sriman Achanta
2026-07-09  3:34   ` sashiko-bot
2026-07-09  3:23 ` [PATCH v6 3/9] HID: steelseries: Inline and simplify SRWS1 wheel driver Sriman Achanta
2026-07-09  3:23 ` [PATCH v6 4/9] HID: steelseries: Refactor Arctis driver to use device_info framework Sriman Achanta
2026-07-09  3:33   ` sashiko-bot
2026-07-09  3:23 ` [PATCH v6 5/9] HID: steelseries: Report POWER_SUPPLY_STATUS_FULL when full Sriman Achanta
2026-07-09  3:23 ` [PATCH v6 6/9] HID: steelseries: Correct Arctis 9 battery calibration range Sriman Achanta
2026-07-09  3:23 ` [PATCH v6 7/9] HID: steelseries: Manage battery lifetime with refcounting Sriman Achanta
2026-07-09  3:38   ` sashiko-bot
2026-07-09  3:23 ` [PATCH v6 8/9] HID: steelseries: Add async status interface support Sriman Achanta
2026-07-09  3:37   ` sashiko-bot
2026-07-09  3:23 ` [PATCH v6 9/9] HID: steelseries: Add support for Arctis Nova 5X and Nova 7 families Sriman Achanta
2026-07-10 12:02 ` Bastien Nocera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d77b5dc879741958390232cd1a5d04718d33d9d0.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=bentiss@kernel.org \
    --cc=git@mayer-bgk.de \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@mungewell.org \
    --cc=srimanachanta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox