From: Sergey Shtylyov <sergei.shtylyov@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
linux-input@vger.kernel.org,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Cheng-Yang Chou <yphbchou0911@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Frank Li <Frank.Li@nxp.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] linux/interrupt.h: allow "guard" notation to disable and reenable IRQ with valid IRQ check
Date: Thu, 22 Jan 2026 21:57:16 +0300 [thread overview]
Message-ID: <d9096670-cd01-41c4-9186-847641c4368a@gmail.com> (raw)
In-Reply-To: <CAMuHMdVs_ODx3eByHkU03vopUuLuY7=uRnfTKuai65jNr+xMhA@mail.gmail.com>
On 1/22/26 7:31 PM, Geert Uytterhoeven wrote:
[...]
>>> @@ -242,6 +242,21 @@ extern void irq_wake_thread(unsigned int irq, void *dev_id);
>>> DEFINE_LOCK_GUARD_1(disable_irq, int,
>>> disable_irq(*_T->lock), enable_irq(*_T->lock))
>>>
>>> +static inline void disable_valid_irq(unsigned int irq)
>>> +{
>>> + if (irq > 0)
>>> + disable_irq(irq);
>>> +}
>>
>> | $ grep " 0:" /proc/interrupts
>> | 0: 43 0 IO-APIC 2-edge timer
>>
>> in other words, interrupt 0 is valid.
>
> AFAIK, the x86 legacy timer interrupt is the sole remaining valid user
> of interrupt number zero.
> Nowadays lots of code assumes valid interrupt numbers are non-zero
> positive numbers.
Makes me remember this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce753ad1549cbe9ccaea4c06a1f5fa47432c8289
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergey
next prev parent reply other threads:[~2026-01-22 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 23:23 [PATCH 1/2] linux/interrupt.h: allow "guard" notation to disable and reenable IRQ with valid IRQ check Marek Vasut
2026-01-21 23:23 ` [PATCH 2/2] Input: ili210x - convert to disable_valid_irq scoped guard Marek Vasut
2026-01-22 15:38 ` [PATCH 1/2] linux/interrupt.h: allow "guard" notation to disable and reenable IRQ with valid IRQ check Frank Li
2026-01-22 19:11 ` Marek Vasut
2026-01-22 16:22 ` Sebastian Andrzej Siewior
2026-01-22 16:31 ` Geert Uytterhoeven
2026-01-22 18:38 ` Dmitry Torokhov
2026-01-22 18:57 ` Sergey Shtylyov [this message]
2026-01-23 10:52 ` Thomas Gleixner
2026-01-25 5:30 ` Dmitry Torokhov
2026-01-27 9:14 ` Thomas Gleixner
2026-01-28 12:23 ` Marek Vasut
2026-01-28 13:49 ` Thomas Gleixner
2026-01-28 14:33 ` Marek Vasut
2026-02-12 18:44 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9096670-cd01-41c4-9186-847641c4368a@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=bigeasy@linutronix.de \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=maz@kernel.org \
--cc=peterz@infradead.org \
--cc=ruanjinjie@huawei.com \
--cc=tglx@kernel.org \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox