Re: [PATCH] HID: multitouch: Add MT_QUIRK_FORCE_GET_FEATURE to MT_CLS_WIN_8 quirks

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 5/1/20 11:56 AM, Hans de Goede wrote:
> The touchpad on the Dell Venue 11 Pro 7130's keyboard-dock is multi-touch
> capable, using HID_GROUP_MULTITOUCH_WIN_8 and the hid-multitouch driver
> correctly binds to it.
> 
> But instead of getting multi-touch HID input reports we still get mouse
> input reports and corresponding linux input (evdev) node events.
> 
> Unloading and reloading the hid-multitouch driver works around this.
> 
> Adding the MT_QUIRK_FORCE_GET_FEATURE quirk to the MT_CLS_WIN_8 quirks
> makes the driver work correctly the first time it is loaded.
> 
> I've chosen to add this quirk to the generic MT_CLS_WIN_8 quirks
> because it seems unlikely that this quirk will causes problems for
> other MT_CLS_WIN_8 devices and if this device needs it other Win 8
> compatible devices might need it too.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Self nack for now, there are more issues with this detachable keyboard,
it sometimes does not work after being unplugged and replugged again
USB_QUIRK_DELAY_INIT seems to help a bit, but is not a total solution...

Dell has some firmware updates for the kbd. So I'll install Windows and
then update the firmware and we'll see from there.

Regards,

Hans



> ---
>   drivers/hid/hid-multitouch.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 362805ddf377..f9c0429e7348 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -265,6 +265,7 @@ static const struct mt_class mt_classes[] = {
>   			MT_QUIRK_IGNORE_DUPLICATES |
>   			MT_QUIRK_HOVERING |
>   			MT_QUIRK_CONTACT_CNT_ACCURATE |
> +			MT_QUIRK_FORCE_GET_FEATURE |
>   			MT_QUIRK_STICKY_FINGERS |
>   			MT_QUIRK_WIN8_PTP_BUTTONS,
>   		.export_all_inputs = true },
>