Linux Input/HID development
 help / color / mirror / Atom feed
From: simon@mungewell.org
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Frank Praznik <frank.praznik@oh.rr.com>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 2/4] HID: sony: Use standard output reports instead of raw reports to send data to the Dualshock 4.
Date: Fri, 17 Jan 2014 12:10:25 -0500	[thread overview]
Message-ID: <da65806f5e5ea0f18f50f882ca569419.squirrel@mungewell.org> (raw)
In-Reply-To: <CANq1E4R3ryPDaivJE-TW=zBnOp9yD5+=-vpVP9zy9OACvud1yw@mail.gmail.com>


>> Use regular HID output reports instead of raw reports in the
>> dualshock4_state_worker function.  (Thanks Simon Mungewell)
>
> This description is actually wrong. hid_output_raw_report() is used
> for regular HID output reports. What you do, is using SET_REPORT to
> synchronously set output-reports. Anyhow, see below for comments.

Hi David,
Can you please confirm whether it is preferred to control the DS4 via
'hid_hw_request()' rather than 'hid_output_raw_report()'? They both appear
to work OK...

For the BT connected device we will have to use a different packet to a
different report.

Simon


  reply	other threads:[~2014-01-17 17:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17  2:42 [PATCH 2/4] HID: sony: Use standard output reports instead of raw reports to send data to the Dualshock 4 Frank Praznik
2014-01-17 11:09 ` David Herrmann
2014-01-17 17:10   ` simon [this message]
2014-01-17 17:15     ` David Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da65806f5e5ea0f18f50f882ca569419.squirrel@mungewell.org \
    --to=simon@mungewell.org \
    --cc=dh.herrmann@gmail.com \
    --cc=frank.praznik@oh.rr.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox