From: Basavaraj Natikar <bnatikar@amd.com>
To: Jiri Kosina <jikos@kernel.org>,
Denis Benato <benato.denis96@gmail.com>,
Basavaraj Natikar <basavaraj.natikar@amd.com>
Cc: Benjamin Tissoires <bentiss@kernel.org>,
"Luke D. Jones" <luke@ljones.dev>,
Ivan Dovgal <iv.dovg@gmail.com>, Adrian Freund <adrian@freund.io>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] HID: amd_sfh: Add support for tablet mode
Date: Thu, 24 Apr 2025 15:21:30 +0530 [thread overview]
Message-ID: <db1d95be-e92a-4328-b43e-8214a0b520be@amd.com> (raw)
In-Reply-To: <19norq05-rp74-9qrr-382r-40q9r59p1pnn@xreary.bet>
On 4/24/2025 2:57 PM, Jiri Kosina wrote:
> On Sun, 9 Mar 2025, Denis Benato wrote:
>
>> Recently there has been a renewed interest in this patch: ASUS has launched a new z13 model
>> and many more users requested tablet mode support for previous models.
>>
>> I have made required adjustments to apply cleanly on top of linux-next:
>> nothing substantial, a macro has been changed from 5 to 6 upstream as
>> the previous patch also did and a few line changed their position.
>>
>> Given there were no functional changes at all I took
>> the liberty to retain previous tags.
>>
>> Denis Benato (1):
>> HID: amd_sfh: Add support for tablet mode switch sensors
>>
>> drivers/hid/amd-sfh-hid/amd_sfh_client.c | 2 ++
>> drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 4 +++
>> drivers/hid/amd-sfh-hid/amd_sfh_pcie.h | 1 +
>> .../hid_descriptor/amd_sfh_hid_desc.c | 27 +++++++++++++++++++
>> .../hid_descriptor/amd_sfh_hid_desc.h | 8 ++++++
>> .../hid_descriptor/amd_sfh_hid_report_desc.h | 20 ++++++++++++++
>> 6 files changed, 62 insertions(+)
> Basavaraj, could you please provide your Acked-by/Reviewed-by: for this
> (or any other sort of feedback)?
Sure, Jiri, I will get back to this patch soon.
We are reviewing similar features and related issues,
and we may need some more time to investigate them internally.
Therefore, I would like to hold off on this patch for a little longer
before providing feedback.
Thanks,
--
Basavaraj
>
> Thanks,
>
next prev parent reply other threads:[~2025-04-24 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 19:49 [PATCH 0/1] HID: amd_sfh: Add support for tablet mode Denis Benato
2025-03-09 19:49 ` [PATCH 1/1] HID: amd_sfh: Add support for tablet mode switch sensors Denis Benato
2025-04-24 9:27 ` [PATCH 0/1] HID: amd_sfh: Add support for tablet mode Jiri Kosina
2025-04-24 9:51 ` Basavaraj Natikar [this message]
2025-04-24 11:07 ` Jiri Kosina
2025-08-15 9:12 ` Paweł Kotiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db1d95be-e92a-4328-b43e-8214a0b520be@amd.com \
--to=bnatikar@amd.com \
--cc=adrian@freund.io \
--cc=basavaraj.natikar@amd.com \
--cc=benato.denis96@gmail.com \
--cc=bentiss@kernel.org \
--cc=iv.dovg@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).