From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2C5D3B290 for ; Sun, 2 Jun 2024 13:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717333922; cv=none; b=flUAVkJp24H+pJQLGStCIeFEAwMPlVl9sndN3//opc+MP/jW8EnvmtPxHF0uzT8AN9P2+rbvCSnNoe/LnWBfDM/S4yoYsXstrjyBtOlUrG6xjS/3f+WV/qbMm5Z3igcFt5cPI96nDPKGSkyaTEWv1U3oYQcrJEFYDE4tDu+9gwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717333922; c=relaxed/simple; bh=2GMUmJaCJgJWhPFJc+yWwe+VhrROglra3N0uKWLVOh8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dtzm1V0ev90wzisR08P2y///jfV151bfXpk35aqCmp7HEQXzWVPeMvHuK2s3DucnrvUBE9CBKBPSr59qpR7np73ssTDhtDahCd6RwQmEZnsxXQblRC4d0FDhAWEN70LBfUXhL2zGUxcIVuKNnUmMYdFCQksws0fBxQ8UayyW66I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fAiPucD5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fAiPucD5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717333918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U0XpR6MtB9rZpzO4h9gBQ8laqSK6cXB++GHXDIh/wbM=; b=fAiPucD5C4HaKy9+mHMK7xL4iliVR/2IiIoNYJ6aiDAAXDU1j84KlcZtaODxaY11DTxE7l tBGxCujt+RVPRsquD4KNlBgIvNQPgDo9bC6Y336MVvb29PM52j3d3KzNNXs8Ax1qliTNmQ JxluH+QFTPVm7yAsyOy0Csm1zwfTfaU= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-dXL65b0_OYO6JQV-R9pNOA-1; Sun, 02 Jun 2024 09:11:57 -0400 X-MC-Unique: dXL65b0_OYO6JQV-R9pNOA-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a6840dde124so182599866b.1 for ; Sun, 02 Jun 2024 06:11:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717333916; x=1717938716; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U0XpR6MtB9rZpzO4h9gBQ8laqSK6cXB++GHXDIh/wbM=; b=U6OMjjmqoYbMY+oQE9zT/ib8yV2rjdzeTLBHO6PYG2+6ImfFn71In3qq31PjSqvWs9 /WBiyL6JreZqUtKVuSGtMsblP+CF4YzuLndmhDQraMDJBkKkEGA5p2lPvsaZrSpDnRsP LX7tUT39GiovpuGfQxoPLVl0pi6V4rnH2XLgFiZJf0MKHmN8rNgrkY8gmwCVg5CHj3MN +sO7cX8+Ichjb1EbBt7SRVpvvIvjjLR8gvI3IcAGv1rczZ5Kf2lRmMML9fj8ltZ6ONUg W8Wuzd1OjqCKa+d/o4UqvzXwaU/S23q241dhPmwhnL+2lWcbyG4h9Tbjec3Ibji1IvJq CMXQ== X-Gm-Message-State: AOJu0Yyg31BiGPAwDjfsoqGs1fzux44BFqWWhvDqNX3eAvFpZ0EwtX+b NA+af6XmX1ugNn/CvGrQUWtPCQQCUsOw9uC4bGPAyox3TqsCkj8iJoBSLigG9kXLHWIVHUaguWK azNROD7DFRry/6HeOgB0qqZJBrd+SHP4gppJOMu+KqMez1gaV28y6Ti+YHNpW X-Received: by 2002:a17:906:7d98:b0:a68:f43c:57dd with SMTP id a640c23a62f3a-a68f43c5841mr107344066b.23.1717333916410; Sun, 02 Jun 2024 06:11:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEOZ1rq8RQPARbuxxDkwmIdMGn2ODnvAXC8CwKpjJc3umM3j7IBJTh7ebS9LrARQHHxc3xH1w== X-Received: by 2002:a17:906:7d98:b0:a68:f43c:57dd with SMTP id a640c23a62f3a-a68f43c5841mr107341366b.23.1717333915865; Sun, 02 Jun 2024 06:11:55 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a68f9ab9ebcsm70976166b.96.2024.06.02.06.11.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jun 2024 06:11:55 -0700 (PDT) Message-ID: Date: Sun, 2 Jun 2024 15:11:54 +0200 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] Input: novatek-nvt-ts: replace generic i2c device id with specific IC variant To: joelselvaraj.oss@gmail.com, Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20240601-nvt-ts-devicetree-regulator-support-v5-0-aa9bf986347d@gmail.com> <20240601-nvt-ts-devicetree-regulator-support-v5-1-aa9bf986347d@gmail.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20240601-nvt-ts-devicetree-regulator-support-v5-1-aa9bf986347d@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 6/1/24 10:44 PM, Joel Selvaraj via B4 Relay wrote: > From: Joel Selvaraj > > This is done in preparation to introduce other variants of the Novatek NVT > touchscreen controller that can be supported by the driver. > > Signed-off-by: Joel Selvaraj Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/input/touchscreen/novatek-nvt-ts.c | 2 +- > drivers/platform/x86/x86-android-tablets/other.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/novatek-nvt-ts.c b/drivers/input/touchscreen/novatek-nvt-ts.c > index 1a797e410a3fa..9bee3a0c122fb 100644 > --- a/drivers/input/touchscreen/novatek-nvt-ts.c > +++ b/drivers/input/touchscreen/novatek-nvt-ts.c > @@ -278,7 +278,7 @@ static int nvt_ts_probe(struct i2c_client *client) > } > > static const struct i2c_device_id nvt_ts_i2c_id[] = { > - { "NVT-ts" }, > + { "nt11205-ts" }, > { } > }; > MODULE_DEVICE_TABLE(i2c, nvt_ts_i2c_id); > diff --git a/drivers/platform/x86/x86-android-tablets/other.c b/drivers/platform/x86/x86-android-tablets/other.c > index eb0e55c69dfed..129273df0fdeb 100644 > --- a/drivers/platform/x86/x86-android-tablets/other.c > +++ b/drivers/platform/x86/x86-android-tablets/other.c > @@ -40,7 +40,7 @@ static const struct x86_i2c_client_info acer_b1_750_i2c_clients[] __initconst = > { > /* Novatek NVT-ts touchscreen */ > .board_info = { > - .type = "NVT-ts", > + .type = "nt11205-ts", > .addr = 0x34, > .dev_name = "NVT-ts", > }, >