From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD6F281ABB for ; Tue, 9 Apr 2024 10:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712657771; cv=none; b=nCRFvor03y9se2cur3rT2RLupaL9lk+w0W/as8Q+s37jNWRSsaKsR0httIZyCYE5z/Sq7fmg7vbBFIF0qYmxRE2QX+EZq1QGopq4xlyBu5KL9W1XqF58CAaQzVBJ+HhO4Xox8j8iVg2hyjkxi+fc0+wH19kQYXrtgXuJQnAnEH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712657771; c=relaxed/simple; bh=SBYSZeuDuqQ415H7h7fcMx9tUPGz1q1BRTWKuCD0r00=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AwgPjOaPx6UXtgbJ7HgmpYt7EJFaFIxyApzRssazO/A+Aoez9uij70ajQR3742aCkThK0K+dEwxY8ChlDG65hatHocK2Lcjh07NB+/YgHClaUy/yycq++A5Hd6F2ni8iV85ZiaW0nK0cj4Q+V4fQEqh2EdN16woCPjUcbilkUTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q4XIOmbT; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q4XIOmbT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712657768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aMeePPemknPpIlqp3R4BbTMH+iMIzQbR2BJB446CC8o=; b=Q4XIOmbThfheYW++kc+F06kcjrNGC8tP3rPxSAy1Jnjm96OM3TftClT511J1tuHS120RxF 3OjZ7umHEIlvIikhdAl9w2oJJN3+6bK4V8n2nWUN8roey9fIowdhvfg4GXgDVsI695uX14 +52kyPCSO4Lo7pLemSNcpWDZUaqvNGM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-fDtI-3myMwyiI4XFFK7UtA-1; Tue, 09 Apr 2024 06:16:07 -0400 X-MC-Unique: fDtI-3myMwyiI4XFFK7UtA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a519e05fe4fso301217866b.3 for ; Tue, 09 Apr 2024 03:16:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712657766; x=1713262566; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aMeePPemknPpIlqp3R4BbTMH+iMIzQbR2BJB446CC8o=; b=JuZk2G/1F1jDoBzg3768GeUJ1bXPFSvDivpoeHIXbFcvhuFlfzwOC8V+iranCCdv8a g4zwN1vEu9EOxRIap9ctuHAMxBs2wqyHDJYplMrBy5rzv819luVRrNWjvDHoFN0SLggy PKVGttSXaset1RibHGX5ZxXsYkNP4RqXaec+dxrZVKqp1RG0LF1Pn85BnPnYkIACsfE9 nT4932KEITOgv0tI5rDWGJd1TWHD/wnjgEzfa59+QagDLRO/2WclbkYJnRAhMaVhfJdf MLwwG6gfK1h6NuMEIPM4GIxQyxjKHcO6OUuuFzHlrNxWNswKiIZSTSKuqGVbbS1FvKed xYFg== X-Forwarded-Encrypted: i=1; AJvYcCXZbPD/LzLbv8IKisqkflhYod+beaJ+5Nnqb+hHC1bYP3TYOJZAViTm62TidIeHg7sLe3yQ84rtrRA5A6zclrG1mW8n25yYqndEhWo= X-Gm-Message-State: AOJu0YyPigR/e7ZRR3N2CeGz4QUU/8mtNr12llQCJ8fUs1OaLbytw9ZL E7TTvl4qzVZjkeDVXs6aqBTaM7Kyr5K6mcasAmN1IMZuHntbL7aJ+ZsLFxvYBAUyv8O0gMVmMQi 88ea7uKDnKOK3O20Z9OB8NQ1D0UeKtZeXOfVidW8GLbrLRniYgtde1cBjKtOYPL6KEkkP9hU= X-Received: by 2002:a17:907:980c:b0:a4e:e61:b5fa with SMTP id ji12-20020a170907980c00b00a4e0e61b5famr10411688ejc.15.1712657766193; Tue, 09 Apr 2024 03:16:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNC0SM3GLkJe2l6pl8yMpUjris79RVE1HgtJTa1aHHLO8ip+nVXtFxc8Q0SGPPZICM3onLkQ== X-Received: by 2002:a17:907:980c:b0:a4e:e61:b5fa with SMTP id ji12-20020a170907980c00b00a4e0e61b5famr10411673ejc.15.1712657765872; Tue, 09 Apr 2024 03:16:05 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id lg11-20020a170906f88b00b00a4e2db8ffdcsm5493019ejb.111.2024.04.09.03.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 03:16:05 -0700 (PDT) Message-ID: Date: Tue, 9 Apr 2024 12:16:04 +0200 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes To: Mark Pearson , Dmitry Torokhov Cc: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, "platform-driver-x86@vger.kernel.org" , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Nitin Joshi1 , Vishnu Sankar , Peter Hutterer References: <20240324210817.192033-1-mpearson-lenovo@squebb.ca> <20240324210817.192033-2-mpearson-lenovo@squebb.ca> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Dmitry, On 4/9/24 2:00 AM, Mark Pearson wrote: > Hi Dmitry > > On Mon, Apr 8, 2024, at 7:31 PM, Dmitry Torokhov wrote: >> Hi Mark, >> >> On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearson wrote: >>> Add support for new input events on Lenovo laptops that need exporting to >>> user space. >>> >>> Lenovo trackpoints are adding the ability to generate a doubletap event. >>> Add a new keycode to allow this to be used by userspace. >> >> What is the intended meaning of this keycode? How does it differ from >> the driver sending BTN_LEFT press/release twice? > > Double tapping on the trackpoint is a unique event - it's not the same as BTN_LEFT twice. The BIOS will send a new ACPI event for it and it's not meant to be the same as mouse button clicks. To extend a bit on this, this double-tap event is not reported through the PS/2 trackpoint interface at all. Instead it is reported to the OS by the ACPI hotkey notifier, which is used to report various multi-media hotkeys and things like that, this is handled by the thinkpad_apci driver which sofar only reports key-presses. So there is no BTN_LEFT to report twice and if we add a BTN_LEFT then we end up with an input_device which has a bunch of KEYs + BTN_LEFT but no abs/rel axis which will just confuse userspace. We could add a second input_device which looks like a mouse but only ever reports BTN_LEFT double-clicks I guess, but as Mark said the intention is for this double-tap to work more like a hotkey then a double click. Also note that regular taps on the trackstick do nothing. Clicking the mouse buttons of the stick involves pressing separate physical buttons between the trackpad and the keyboard and those are reported over the same PS/2 port as the relative motion events from the stick. Regards, Hans