Linux Input/HID development
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, Ben Chen <ben_chen@bizlinktech.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] HID: cmedia: add support for HS-100B mute button
Date: Mon, 19 Jul 2021 13:24:57 +0200	[thread overview]
Message-ID: <dded786c-e27e-4d78-999c-af99f3778c11@t-8ch.de> (raw)
In-Reply-To: <20210719110911.310701-1-linux@weissschuh.net>

On Mo, 2021-07-19T13:09+0200, Thomas Weißschuh wrote:
> These chips report mute button events in bit 4 of their report without
> it being part of the report descriptor.
> Use a custom descriptor that maps this bit.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> v1: https://lore.kernel.org/linux-input/a769ae40-6d0c-47c4-803f-2c8dbc362f24@t-8ch.de/
> 
> v1 -> v2:
>  * Merged into the existing cmedia driver instead of creating a dedicated
>    driver.
> 
> v2: https://lore.kernel.org/linux-input/20210716160659.154779-1-linux@weissschuh.net/
> 
> v2 -> v3:
>  * Fixed cosmetic checkpatch warnings
>  * CC-ed Ben Chen who is the original author of hid-cmedia.c
> 
>  drivers/hid/Kconfig      |  5 +-
>  drivers/hid/hid-cmedia.c | 99 +++++++++++++++++++++++++++++++++++-----
>  drivers/hid/hid-ids.h    |  1 +
>  drivers/hid/hid-quirks.c |  1 +
>  4 files changed, 93 insertions(+), 13 deletions(-)
> 

FYI:
The Mail to Ben bounced, so we will probably have to do without his review.

Thomas

      reply	other threads:[~2021-07-19 11:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 11:09 [PATCH v3] HID: cmedia: add support for HS-100B mute button Thomas Weißschuh
2021-07-19 11:24 ` Thomas Weißschuh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dded786c-e27e-4d78-999c-af99f3778c11@t-8ch.de \
    --to=linux@weissschuh.net \
    --cc=ben_chen@bizlinktech.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox