From: Marek Vasut <marek.vasut@mailbox.org>
To: Frank Li <Frank.li@nxp.com>
Cc: linux-input@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Job Noorman <job@noorman.info>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: ili210x - add support for polling mode
Date: Thu, 15 Jan 2026 03:10:28 +0100 [thread overview]
Message-ID: <de8a4c1f-8c60-4e3c-bba1-d9808468c8b1@mailbox.org> (raw)
In-Reply-To: <aWZ1pG5RRWlDSCwC@lizhi-Precision-Tower-5810>
On 1/13/26 5:41 PM, Frank Li wrote:
[...]
>> @@ -1003,12 +1027,24 @@ static int ili210x_i2c_probe(struct i2c_client *client)
>> return error;
>> }
>>
>> - error = devm_request_threaded_irq(dev, client->irq, NULL, ili210x_irq,
>> - IRQF_ONESHOT, client->name, priv);
>> - if (error) {
>> - dev_err(dev, "Unable to request touchscreen IRQ, err: %d\n",
>> - error);
>> - return error;
>> + input_set_drvdata(input, priv);
>> +
>> + if (client->irq) {
>
> 0 is validated irq number
>
> https://elixir.bootlin.com/linux/v6.19-rc4/source/drivers/base/platform.c#L284
>
> if (irq < 0)
>
> But it is strange that touch don't connect irq line althougth it works,
> touch generally is wakeup source of system.
Raspi is like that, they poll the touch controllers. It is unfortunate.
next prev parent reply other threads:[~2026-01-15 3:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 23:44 [PATCH 1/2] dt-bindings: touchscreen: trivial-touch: Drop 'interrupts' requirement for old Ilitek Marek Vasut
2026-01-12 23:44 ` [PATCH 2/2] Input: ili210x - add support for polling mode Marek Vasut
2026-01-13 16:41 ` Frank Li
2026-01-14 9:37 ` Geert Uytterhoeven
2026-01-14 15:12 ` Frank Li
2026-01-15 2:10 ` Marek Vasut [this message]
2026-01-13 16:35 ` [PATCH 1/2] dt-bindings: touchscreen: trivial-touch: Drop 'interrupts' requirement for old Ilitek Frank Li
2026-01-15 2:09 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8a4c1f-8c60-4e3c-bba1-d9808468c8b1@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=job@noorman.info \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox