public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3519
@ 2026-03-14 13:50 Bhushan Shah
  2026-03-14 14:07 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Bhushan Shah @ 2026-03-14 13:50 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-input, devicetree, linux-kernel, Bhushan Shah

Document FocalTech FT3519 support by adding the compatible. It's 10
point touchscreen, which is compatible with FT3518

Signed-off-by: Bhushan Shah <bhushan.shah@machinesoul.in>
---
Document FocalTech FT3519 support by adding the compatible. It's 10
point touchscreen, which is compatible with FT3518.
---
Changes in v2:
- Remove the driver change and add only compatible in dt-bindings.
- Link to v1: https://lore.kernel.org/r/20260313-edt-ft3519-v1-0-fe5ffc632fd2@machinesoul.in
---
 .../bindings/input/touchscreen/edt-ft5x06.yaml     | 30 ++++++++++++----------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
index 6f90522de8c0..cc071acc1c72 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
@@ -33,19 +33,23 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - edt,edt-ft5206
-      - edt,edt-ft5306
-      - edt,edt-ft5406
-      - edt,edt-ft5506
-      - evervision,ev-ft5726
-      - focaltech,ft3518
-      - focaltech,ft5426
-      - focaltech,ft5452
-      - focaltech,ft6236
-      - focaltech,ft8201
-      - focaltech,ft8716
-      - focaltech,ft8719
+    oneOf:
+      - enum:
+        - edt,edt-ft5206
+        - edt,edt-ft5306
+        - edt,edt-ft5406
+        - edt,edt-ft5506
+        - evervision,ev-ft5726
+        - focaltech,ft3518
+        - focaltech,ft5426
+        - focaltech,ft5452
+        - focaltech,ft6236
+        - focaltech,ft8201
+        - focaltech,ft8716
+        - focaltech,ft8719
+      - items:
+        - const: focaltech,ft3519
+        - const: focaltech,ft3518
 
   reg:
     maxItems: 1

---
base-commit: 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a
change-id: 20260313-edt-ft3519-b3e2a33e88ee

Best regards,
-- 
Bhushan Shah <bhushan.shah@machinesoul.in>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3519
  2026-03-14 13:50 [PATCH v2] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3519 Bhushan Shah
@ 2026-03-14 14:07 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-14 14:07 UTC (permalink / raw)
  To: Bhushan Shah, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-input, devicetree, linux-kernel

On 14/03/2026 14:50, Bhushan Shah wrote:
> Document FocalTech FT3519 support by adding the compatible. It's 10
> point touchscreen, which is compatible with FT3518
> 
> Signed-off-by: Bhushan Shah <bhushan.shah@machinesoul.in>
> ---
> Document FocalTech FT3519 support by adding the compatible. It's 10
> point touchscreen, which is compatible with FT3518.
> ---
> Changes in v2:
> - Remove the driver change and add only compatible in dt-bindings.
> - Link to v1: https://lore.kernel.org/r/20260313-edt-ft3519-v1-0-fe5ffc632fd2@machinesoul.in
> ---

It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-14 14:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-14 13:50 [PATCH v2] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3519 Bhushan Shah
2026-03-14 14:07 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox