From: Hans de Goede <hdegoede@redhat.com>
To: Icenowy Zheng <icenowy@aosc.xyz>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree <devicetree@vger.kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: touchscreen: silead gsl1680: Document all compatibles
Date: Wed, 17 Aug 2016 10:58:26 +0200 [thread overview]
Message-ID: <df9de5f7-97af-269d-d901-5d7bb134b069@redhat.com> (raw)
In-Reply-To: <46861471402766@web24j.yandex.ru>
Hi,
On 17-08-16 04:59, Icenowy Zheng wrote:
>
>
> 16.08.2016, 17:06, "Hans de Goede" <hdegoede@redhat.com>:
>> The silead gsl1680 driver / binding supports a whole series of devices,
>> list the compatibles for all of them in the binding.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> .../devicetree/bindings/input/touchscreen/silead_gsl1680.txt | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt b/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
>> index 1112e0d..37a9370 100644
>> --- a/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
>> @@ -2,6 +2,11 @@
>>
>> Required properties:
>> - compatible : "silead,gsl1680"
>> + or: "silead,gsl1688"
>> + or: "silead,gsl3670"
>> + or: "silead,gsl3675"
>> + or: "silead,gsl3692"
>> + or: "silead,mssl1680"
> I think “mssl1680" is only a string which exists in ACPI tables.
> I have disassembled one of my tablet, which is said to have "MSSL1680" in it in
> ACPI table (a BayTrail tablet). What I got is a plain GSL1680.
> So it shouldn't exist in the compatible list.
Ah, right, I was already wondering about that one I guess mssl stands for
"microsoft silead" (just a guess). Anyways I'll send a v2 dropping it.
Thanks & Regards,
Hans
>> - reg : I2C slave address of the chip (0x40)
>> - interrupt-parent : a phandle pointing to the interrupt controller
>> serving the interrupt for this chip
>> --
>> 2.7.4
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2016-08-17 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 9:01 [PATCH] dt-bindings: touchscreen: silead gsl1680: Document all compatibles Hans de Goede
2016-08-17 2:59 ` Icenowy Zheng
2016-08-17 8:58 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df9de5f7-97af-269d-d901-5d7bb134b069@redhat.com \
--to=hdegoede@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).