* [PATCH 0/2] Input-TurboGraFX: Adjustments for tgfx_attach()
@ 2018-01-27 14:58 SF Markus Elfring
2018-01-27 14:59 ` [PATCH 1/2] Input: turbografx: Delete an error message for a failed memory allocation in tgfx_attach() SF Markus Elfring
2018-01-27 15:00 ` [PATCH 2/2] Input: turbografx: Improve a size determination " SF Markus Elfring
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-01-27 14:58 UTC (permalink / raw)
To: linux-input, Dmitry Torokhov, Geliang Tang, Kees Cook
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 15:55:44 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/input/joystick/turbografx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--
2.16.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] Input: turbografx: Delete an error message for a failed memory allocation in tgfx_attach()
2018-01-27 14:58 [PATCH 0/2] Input-TurboGraFX: Adjustments for tgfx_attach() SF Markus Elfring
@ 2018-01-27 14:59 ` SF Markus Elfring
2018-01-27 15:00 ` [PATCH 2/2] Input: turbografx: Improve a size determination " SF Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-01-27 14:59 UTC (permalink / raw)
To: linux-input, Dmitry Torokhov, Geliang Tang, Kees Cook
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 15:43:38 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/input/joystick/turbografx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
index e2685753e460..454d4c032292 100644
--- a/drivers/input/joystick/turbografx.c
+++ b/drivers/input/joystick/turbografx.c
@@ -192,10 +192,8 @@ static void tgfx_attach(struct parport *pp)
}
tgfx = kzalloc(sizeof(struct tgfx), GFP_KERNEL);
- if (!tgfx) {
- printk(KERN_ERR "turbografx.c: Not enough memory\n");
+ if (!tgfx)
goto err_unreg_pardev;
- }
mutex_init(&tgfx->sem);
tgfx->pd = pd;
--
2.16.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] Input: turbografx: Improve a size determination in tgfx_attach()
2018-01-27 14:58 [PATCH 0/2] Input-TurboGraFX: Adjustments for tgfx_attach() SF Markus Elfring
2018-01-27 14:59 ` [PATCH 1/2] Input: turbografx: Delete an error message for a failed memory allocation in tgfx_attach() SF Markus Elfring
@ 2018-01-27 15:00 ` SF Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-01-27 15:00 UTC (permalink / raw)
To: linux-input, Dmitry Torokhov, Geliang Tang, Kees Cook
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 15:46:24 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/input/joystick/turbografx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
index 454d4c032292..472bc438927e 100644
--- a/drivers/input/joystick/turbografx.c
+++ b/drivers/input/joystick/turbografx.c
@@ -191,7 +191,7 @@ static void tgfx_attach(struct parport *pp)
return;
}
- tgfx = kzalloc(sizeof(struct tgfx), GFP_KERNEL);
+ tgfx = kzalloc(sizeof(*tgfx), GFP_KERNEL);
if (!tgfx)
goto err_unreg_pardev;
--
2.16.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-27 15:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-27 14:58 [PATCH 0/2] Input-TurboGraFX: Adjustments for tgfx_attach() SF Markus Elfring
2018-01-27 14:59 ` [PATCH 1/2] Input: turbografx: Delete an error message for a failed memory allocation in tgfx_attach() SF Markus Elfring
2018-01-27 15:00 ` [PATCH 2/2] Input: turbografx: Improve a size determination " SF Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).