From: Randy Dunlap <rdunlap@infradead.org>
To: Ilya Skriblovsky <ilyaskriblovsky@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Support for side buttons of Xiaomi Mi Dual Mode Wireless Mouse Silent Edition
Date: Thu, 16 Sep 2021 13:00:11 -0700 [thread overview]
Message-ID: <e02a942b-286a-7185-3a45-d77af9b5cc6f@infradead.org> (raw)
In-Reply-To: <YUOg5aDkO0lp7eM8@ilya-330s>
Hi,
On 9/16/21 12:54 PM, Ilya Skriblovsky wrote:
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 76937f716fbe..d09abc63290e 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -467,6 +467,13 @@ config HID_VIEWSONIC
> help
> Support for ViewSonic/Signotec PD1011 signature pad.
>
> +config HID_XIAOMI:
No ending ':' above.
> + tristate "Xiaomi"
> + depends on HID
> + help
> + Adds support for side buttons of Xiaomi Mi Dual Mode Wireless
> + Mouse Silent Edition
End the description with a '.', please.
And the 2 lines of help text should be indented with an extra 2
spaces (although some parts of this Kconfig file are not done
like that and other parts are).
> +
thanks.
--
~Randy
prev parent reply other threads:[~2021-09-16 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 19:54 [PATCH] Support for side buttons of Xiaomi Mi Dual Mode Wireless Mouse Silent Edition Ilya Skriblovsky
2021-09-16 20:00 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e02a942b-286a-7185-3a45-d77af9b5cc6f@infradead.org \
--to=rdunlap@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=ilyaskriblovsky@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).