From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E164C433EF for ; Thu, 16 Sep 2021 20:00:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF0E861164 for ; Thu, 16 Sep 2021 20:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231969AbhIPUBe (ORCPT ); Thu, 16 Sep 2021 16:01:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236082AbhIPUBe (ORCPT ); Thu, 16 Sep 2021 16:01:34 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50B28C061574; Thu, 16 Sep 2021 13:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=O9Ii6LJ9LsmL6+RSz1Wyr9Day281eVLBIDqbMWg5CEI=; b=kdO0IA4LIiPOteuRg+V7ustgb3 voPhakwEaqypUeDp87CmypZiruUFBC72IV0RhMC+tCBQn4+PCBKQWIb7BANz0GdBjO8wDebtD2DTx 2dT903GpRsMFpEBqDgBF+vQh1URs6k8OI1It3jWo3fHb42VUVRJdR7MT9j3dXZMEZNWtmCg3WjcES UH+Mv6Pi49TzTLQOzMLLL3qwxxHhbnm0zHTzWk35/BCjGnneoRBt9CREH1IWkWloDiXMLBjIqfq0f Psb1k+1U6QTcxGG406gW3mIA0VDnVmTVDIk18YJpfAt56amlTzhc43wa3PoNGyRPBQAlFSwHz+BT8 NkKvCVCg==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQxYK-00CIRj-Hh; Thu, 16 Sep 2021 20:00:12 +0000 Subject: Re: [PATCH] Support for side buttons of Xiaomi Mi Dual Mode Wireless Mouse Silent Edition To: Ilya Skriblovsky , Jiri Kosina , Benjamin Tissoires , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org References: From: Randy Dunlap Message-ID: Date: Thu, 16 Sep 2021 13:00:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 9/16/21 12:54 PM, Ilya Skriblovsky wrote: > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 76937f716fbe..d09abc63290e 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -467,6 +467,13 @@ config HID_VIEWSONIC > help > Support for ViewSonic/Signotec PD1011 signature pad. > > +config HID_XIAOMI: No ending ':' above. > + tristate "Xiaomi" > + depends on HID > + help > + Adds support for side buttons of Xiaomi Mi Dual Mode Wireless > + Mouse Silent Edition End the description with a '.', please. And the 2 lines of help text should be indented with an extra 2 spaces (although some parts of this Kconfig file are not done like that and other parts are). > + thanks. -- ~Randy