* [PATCH -next] hid: fix hid-logitech-dj build error
@ 2019-05-07 1:12 Randy Dunlap
2019-05-07 7:04 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2019-05-07 1:12 UTC (permalink / raw)
To: LKML, Andrew Morton
Cc: linux-input@vger.kernel.org, Jiri Kosina, Benjamin Tissoires,
kbuild test robot
From: Randy Dunlap <rdunlap@infradead.org>
Fix build error in hid-logitech-dj by making it depend on
USB_HID, like several other HID drivers do.
Fixes this build error:
ERROR: "usb_hid_driver" [drivers/hid/hid-logitech-dj.ko] undefined!
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- mmotm-2019-0425-1630.orig/drivers/hid/Kconfig
+++ mmotm-2019-0425-1630/drivers/hid/Kconfig
@@ -522,6 +522,7 @@ config HID_LOGITECH
config HID_LOGITECH_DJ
tristate "Logitech Unifying receivers full support"
depends on HIDRAW
+ depends on USB_HID
depends on HID_LOGITECH
select HID_LOGITECH_HIDPP
---help---
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] hid: fix hid-logitech-dj build error
2019-05-07 1:12 [PATCH -next] hid: fix hid-logitech-dj build error Randy Dunlap
@ 2019-05-07 7:04 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2019-05-07 7:04 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, Andrew Morton, linux-input@vger.kernel.org, Jiri Kosina,
kbuild test robot
Hi Randy,
On Tue, May 7, 2019 at 3:12 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error in hid-logitech-dj by making it depend on
> USB_HID, like several other HID drivers do.
>
> Fixes this build error:
>
> ERROR: "usb_hid_driver" [drivers/hid/hid-logitech-dj.ko] undefined!
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: linux-input@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- mmotm-2019-0425-1630.orig/drivers/hid/Kconfig
> +++ mmotm-2019-0425-1630/drivers/hid/Kconfig
> @@ -522,6 +522,7 @@ config HID_LOGITECH
> config HID_LOGITECH_DJ
> tristate "Logitech Unifying receivers full support"
> depends on HIDRAW
> + depends on USB_HID
this is already scheduled in the HID PR:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-linus&id=c08f38e9fd0b5486957ed42438ec8fa9b6ebbf4f
Cheers,
Benjamin
> depends on HID_LOGITECH
> select HID_LOGITECH_HIDPP
> ---help---
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-07 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-07 1:12 [PATCH -next] hid: fix hid-logitech-dj build error Randy Dunlap
2019-05-07 7:04 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).