From: Lyude Paul <lyude@redhat.com>
To: Vincent Huang <vincent.huang@tw.synaptics.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Andrew Duggan <aduggan@synaptics.com>,
Hans de Goede <hdegoede@redhat.com>,
Benjamin Tissoires <btissoir@redhat.com>,
Chris Heiny <chris.heiny@synaptics.com>
Subject: Re: [PATCH v3 0/2] Add support for F3A
Date: Wed, 30 Sep 2020 16:17:31 -0400 [thread overview]
Message-ID: <e347d9fbd20a778a5610b33e1dfb9966a14dfd8a.camel@redhat.com> (raw)
In-Reply-To: <20200930094147.635556-1-vincent.huang@tw.synaptics.com>
For the whole series:
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Wed, 2020-09-30 at 17:41 +0800, Vincent Huang wrote:
> RMI4 F3A supports the touchpad GPIO function, it's designed to support
> more GPIOs and used on newer touchpads. The patches add support of
> touchpad buttons and rename f30_data to avoid confusion.
>
> Changes in v2:
> - Combined patch 1 and 2 of v1 to fix bisectability.
>
> Changes in v3:
> - Fix indentations pointed out by Lyude Paul.
>
> Vincent Huang (2):
> Input: synaptics-rmi4 - rename f30_data to gpio_data
> Input: synaptics-rmi4 - add support for F3A
>
> drivers/hid/hid-rmi.c | 2 +-
> drivers/input/mouse/synaptics.c | 2 +-
> drivers/input/rmi4/Kconfig | 8 ++
> drivers/input/rmi4/Makefile | 1 +
> drivers/input/rmi4/rmi_bus.c | 3 +
> drivers/input/rmi4/rmi_driver.h | 1 +
> drivers/input/rmi4/rmi_f30.c | 14 +-
> drivers/input/rmi4/rmi_f3a.c | 240 ++++++++++++++++++++++++++++++++
> include/linux/rmi.h | 11 +-
> 9 files changed, 268 insertions(+), 14 deletions(-)
> create mode 100644 drivers/input/rmi4/rmi_f3a.c
>
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
prev parent reply other threads:[~2020-09-30 20:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 9:41 [PATCH v3 0/2] Add support for F3A Vincent Huang
2020-09-30 9:41 ` [PATCH v3 1/2] Input: synaptics-rmi4 - rename f30_data to gpio_data Vincent Huang
2020-10-01 1:43 ` Andrew Duggan
2020-10-05 2:45 ` Dmitry Torokhov
2020-09-30 9:41 ` [PATCH v3 2/2] Input: synaptics-rmi4 - add support for F3A Vincent Huang
2020-10-01 1:45 ` Andrew Duggan
2020-10-05 2:45 ` Dmitry Torokhov
2020-09-30 20:17 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e347d9fbd20a778a5610b33e1dfb9966a14dfd8a.camel@redhat.com \
--to=lyude@redhat.com \
--cc=aduggan@synaptics.com \
--cc=btissoir@redhat.com \
--cc=chris.heiny@synaptics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).